fix: eight open issues across jobs, watcher, validator, simulator, MCP graph_name, JS/TS imports, .NET ignore defaults and dev-env pins - #1646
Merged
Conversation
…1537) Active jobs with recent progress survive the sweep; a RUNNING/PENDING job with no update for the whole window is flipped to FAILED (still visible to check_job_status) instead of vanishing, and ages out via the terminal path.
A stopped Observer cannot be restarted; stale entries made watch_directory answer 'Already watching' for a dead observer.
…ds as identifiers (#1511) Keywords in provably-safe positions (property access, label/rel-type, parameter, AS-alias) no longer trip the read-only gate; clause-position writes are still rejected, including a real SET/DELETE following an alias.
labels(<var>)[0] is now rewritten for any variable name (the literal labels(n)[0] replace missed n1/n2), and the relationship query's bare pattern predicate is restructured as a CONTAINS*0.. match.
#1558); drop last shadowed method (#1604) GraphBuilder accepts a graph_name and binds its writer to get_driver(graph_name); the handler builds a scoped builder on FalkorDB and refuses explicitly on single-graph backends instead of silently indexing into the default graph. Also removes the remaining shadowed add_repository_to_graph definition #1619 missed.
obj/ contains generated source (AssemblyInfo.cs, GlobalUsings.g.cs) that added phantom File/Module/IMPORTS rows to the graph. The golden test already masks obj/ via GENERATED_BUILD_DIRS, so the drift never failed the test — it only rotted the recorded golden. With the indexer itself excluding obj/, raw output matches the comparison scope and the C# golden regenerates with zero logical drift (the CALLS 12→7 loss reported in #1585 no longer reproduces on current main; it was fixed by intervening parser merges).
…1526) import_clause is an unnamed child of import_statement, so child_by_field_name('import') always returned None and every ES import collapsed into the bare-module fallback — the entire binding-extraction block was dead code, and would have tested the wrong node types anyway. The clause's children are now walked (a single clause can carry a default and named bindings together), the namespace alias is read from the identifier child, and both grammars are covered by binding-level tests. Downstream effects, captured in the regenerated goldens: IMPORTS edges carry the real binding in imported_name (was the module path), and 4 TypeScript call edges upgraded from HEURISTIC_CALLS to resolved CALLS because named-import bindings now reach the imports map.
…project pin (#1625) A stale venv holding an out-of-pin grammar pack makes the parser suite pass while disagreeing with CI (the #1600 misparse exists on 1.14.x but not 0.13.x, which nearly got a correct fix closed as a no-op). The divergence is now a named test failure pointing at the venv, not the parser.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ |
Contributor
🔍 PR Code Graph Analysisfix: eight open issues across jobs, watcher, validator, simulator, MCP graph_name, JS/TS imports, .NET ignore defaults and dev-env pins (#1646) 📊 Interactive VisualizationView the blast radius graph: PR Reviewer Dashboard 📦 ArtifactsThe graph JSON has been uploaded as a build artifact: Generated by CodeGraphContext using FalkorDB Lite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working through the open backlog, one commit per issue. Every fix carries its own regression tests; full unit suite 1388 passed / 19 skipped, full integration suite 51 passed (all 21 goldens) at the branch head.
bc98f265cleanup_old_jobsdeleted RUNNING/PENDING jobs mid-index; progress updates silently no-oped andcheck_job_statussaid not_found while the worker kept writing. Active jobs now survive the sweep; a stalled one (no update for the whole window) flips to FAILED instead of vanishing.9b7ba755CodeWatcher.stop()leftwatched_paths/watchespopulated, so a reused instance answered "Already watching" for a dead observer.c930a192load/set/update/insertas a property, label, param or alias. Keywords now only trip the gate in clause position; a realSET/DELETEafter an alias is still rejected (verified against a 17-query allow/reject corpus).6c53d70asimulate_metricsfailed on every KùzuDB/LadybugDB database:labels(n1)[0]missed the translator's literal-only rewrite and the bare pattern predicate can't be planned. Rewrite is now variable-agnostic and the query usesCONTAINS*0..; covered by a real-Kùzu test.4787f753add_code_to_graphdeclaredgraph_nameand ignored it. It now builds a scopedGraphBuilderbound toget_driver(graph_name)on FalkorDB, and refuses explicitly on single-graph backends instead of silently indexing into the default graph. Also removes the last shadowedadd_repository_to_graph#1619 missed.96554adcobj/build output — generated source the golden test masks (GENERATED_BUILD_DIRS) but--update-goldensrecords.obj/is now in both default-ignore sources, so raw output matches the comparison scope and the golden regenerates with zero logical drift. The reported CALLS 12→7 loss no longer reproduces (fixed by intervening parser merges).4dcbf591import_clauseis an unnamed child, sochild_by_field_name('import')was always None and the binding-extraction block was dead code. Named/default/namespace bindings (including combinedimport Def, { a as b }) now extract in both grammars. Regenerated goldens show IMPORTS edges carrying real bindings and 4 TS call edges upgrading from HEURISTIC_CALLS to resolved CALLS.3e9a…tree-sitter-language-packmakes the parser suite pass while disagreeing with CI (nearly got #1610 closed as a no-op). The divergence is now a named test failure pointing at the venv.Fixes #1537, fixes #1519, fixes #1511, fixes #1512, fixes #1558, fixes #1604, fixes #1585, fixes #1526, fixes #1625