Skip to content

fix: eight open issues across jobs, watcher, validator, simulator, MCP graph_name, JS/TS imports, .NET ignore defaults and dev-env pins - #1646

Merged
Shashankss1205 merged 8 commits into
mainfrom
fix/core-backlog-batch
Aug 18, 2026
Merged

Shashankss1205 merged 8 commits into
mainfrom
fix/core-backlog-batch

Conversation

@Shashankss1205

Copy link
Copy Markdown
Collaborator

Working through the open backlog, one commit per issue. Every fix carries its own regression tests; full unit suite 1388 passed / 19 skipped, full integration suite 51 passed (all 21 goldens) at the branch head.

Commit Issue What was wrong
bc98f265 #1537 cleanup_old_jobs deleted RUNNING/PENDING jobs mid-index; progress updates silently no-oped and check_job_status said not_found while the worker kept writing. Active jobs now survive the sweep; a stalled one (no update for the whole window) flips to FAILED instead of vanishing.
9b7ba755 #1519 CodeWatcher.stop() left watched_paths/watches populated, so a reused instance answered "Already watching" for a dead observer.
c930a192 #1511 The read-only Cypher gate rejected any query merely mentioning load/set/update/insert as a property, label, param or alias. Keywords now only trip the gate in clause position; a real SET/DELETE after an alias is still rejected (verified against a 17-query allow/reject corpus).
6c53d70a #1512 simulate_metrics failed on every KùzuDB/LadybugDB database: labels(n1)[0] missed the translator's literal-only rewrite and the bare pattern predicate can't be planned. Rewrite is now variable-agnostic and the query uses CONTAINS*0..; covered by a real-Kùzu test.
4787f753 #1558, #1604 add_code_to_graph declared graph_name and ignored it. It now builds a scoped GraphBuilder bound to get_driver(graph_name) on FalkorDB, and refuses explicitly on single-graph backends instead of silently indexing into the default graph. Also removes the last shadowed add_repository_to_graph #1619 missed.
96554adc #1585 The C# golden drift was .NET obj/ build output — generated source the golden test masks (GENERATED_BUILD_DIRS) but --update-goldens records. obj/ is now in both default-ignore sources, so raw output matches the comparison scope and the golden regenerates with zero logical drift. The reported CALLS 12→7 loss no longer reproduces (fixed by intervening parser merges).
4dcbf591 #1526 Every JS/TS ES import collapsed to a bare module row: import_clause is an unnamed child, so child_by_field_name('import') was always None and the binding-extraction block was dead code. Named/default/namespace bindings (including combined import Def, { a as b }) now extract in both grammars. Regenerated goldens show IMPORTS edges carrying real bindings and 4 TS call edges upgrading from HEURISTIC_CALLS to resolved CALLS.
3e9a… #1625 A stale venv holding an out-of-pin tree-sitter-language-pack makes the parser suite pass while disagreeing with CI (nearly got #1610 closed as a no-op). The divergence is now a named test failure pointing at the venv.

Fixes #1537, fixes #1519, fixes #1511, fixes #1512, fixes #1558, fixes #1604, fixes #1585, fixes #1526, fixes #1625

…1537)

Active jobs with recent progress survive the sweep; a RUNNING/PENDING job
with no update for the whole window is flipped to FAILED (still visible to
check_job_status) instead of vanishing, and ages out via the terminal path.
A stopped Observer cannot be restarted; stale entries made watch_directory
answer 'Already watching' for a dead observer.
…ds as identifiers (#1511)

Keywords in provably-safe positions (property access, label/rel-type,
parameter, AS-alias) no longer trip the read-only gate; clause-position
writes are still rejected, including a real SET/DELETE following an alias.
labels(<var>)[0] is now rewritten for any variable name (the literal
labels(n)[0] replace missed n1/n2), and the relationship query's bare
pattern predicate is restructured as a CONTAINS*0.. match.
#1558); drop last shadowed method (#1604)

GraphBuilder accepts a graph_name and binds its writer to
get_driver(graph_name); the handler builds a scoped builder on FalkorDB and
refuses explicitly on single-graph backends instead of silently indexing
into the default graph. Also removes the remaining shadowed
add_repository_to_graph definition #1619 missed.
obj/ contains generated source (AssemblyInfo.cs, GlobalUsings.g.cs) that
added phantom File/Module/IMPORTS rows to the graph. The golden test already
masks obj/ via GENERATED_BUILD_DIRS, so the drift never failed the test —
it only rotted the recorded golden. With the indexer itself excluding obj/,
raw output matches the comparison scope and the C# golden regenerates with
zero logical drift (the CALLS 12→7 loss reported in #1585 no longer
reproduces on current main; it was fixed by intervening parser merges).
…1526)

import_clause is an unnamed child of import_statement, so
child_by_field_name('import') always returned None and every ES import
collapsed into the bare-module fallback — the entire binding-extraction
block was dead code, and would have tested the wrong node types anyway.
The clause's children are now walked (a single clause can carry a default
and named bindings together), the namespace alias is read from the
identifier child, and both grammars are covered by binding-level tests.

Downstream effects, captured in the regenerated goldens: IMPORTS edges
carry the real binding in imported_name (was the module path), and 4
TypeScript call edges upgraded from HEURISTIC_CALLS to resolved CALLS
because named-import bindings now reach the imports map.
…project pin (#1625)

A stale venv holding an out-of-pin grammar pack makes the parser suite pass
while disagreeing with CI (the #1600 misparse exists on 1.14.x but not
0.13.x, which nearly got a correct fix closed as a no-op). The divergence is
now a named test failure pointing at the venv, not the parser.
@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
code-graph-context-pack Ready Ready Preview Aug 18, 2026 7:34pm

@github-project-automation github-project-automation Bot moved this to Backlog tasks in CGC Progress Board Aug 18, 2026
@Shashankss1205
Shashankss1205 merged commit e48c3e3 into main Aug 18, 2026
17 of 19 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Code Graph Analysis

fix: eight open issues across jobs, watcher, validator, simulator, MCP graph_name, JS/TS imports, .NET ignore defaults and dev-env pins (#1646)

📊 Interactive Visualization

View the blast radius graph: PR Reviewer Dashboard

📦 Artifacts

The graph JSON has been uploaded as a build artifact: pr-code-graph-1646


Generated by CodeGraphContext using FalkorDB Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment