Rename build job to iMessage - #2
Open
mydickassbusiness wants to merge 4887 commits into
Open
mydickassbusiness wants to merge 4887 commits into
mydickassbusiness wants to merge 4887 commits into
Conversation
The view needs to request a call to `fitsSystemWindows`; otherwise it cannot determine where to layout itself within the parent that uses fitsSystemWindows method to determine the boundary of it. This fixes the issue reported in [the beta 5.3 forum](https://community.signalusers.org/t/beta-feedback-for-the-upcoming-android-5-3-release/25088/315).
There was a race condition where if you created a blob super-early in the application lifecycle, you could create it *before* we deleted the blobs from the previous session, leading you to lose the blob you just created immediately. In an effort to protect our cold start time, I just made a little initialization flow where read/write calls to BlobProvider will block until it's deleted blobs from the old session.
Defensive array list copies where used in builders and Intent#putParcelableArrayListExtra. Spelling.
Co-authored-by: Alan Evans <alan@signal.org>
Instead of trying to keep track of changes as we go and hope that lines up with reality, now we just write all of our changes and do another diff at the end to build our insert/delete set. Nice and simple.
mydickassbusiness
changed the base branch from
master
to
moxie/disappearing_messages
September 10, 2026 20:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription