Skip to content

Rename build job to iMessage - #2

Open
mydickassbusiness wants to merge 4887 commits into
BuildJet:moxie/disappearing_messagesfrom
mydickassbusiness:master
Open

mydickassbusiness wants to merge 4887 commits into
BuildJet:moxie/disappearing_messagesfrom
mydickassbusiness:master

Conversation

@mydickassbusiness

Copy link
Copy Markdown

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

alan-signal and others added 30 commits February 23, 2021 23:59
The view needs to request a call to `fitsSystemWindows`; otherwise it
cannot determine where to layout itself within the parent that uses
fitsSystemWindows method to determine the boundary of it.

This fixes the issue reported in [the beta 5.3 forum](https://community.signalusers.org/t/beta-feedback-for-the-upcoming-android-5-3-release/25088/315).
There was a race condition where if you created a blob super-early in
the application lifecycle, you could create it *before* we deleted the
blobs from the previous session, leading you to lose the blob you just
created immediately.

In an effort to protect our cold start time, I just made a little
initialization flow where read/write calls to BlobProvider will block
until it's deleted blobs from the old session.
Defensive array list copies where used in builders and Intent#putParcelableArrayListExtra.

Spelling.
Co-authored-by: Alan Evans <alan@signal.org>
greyson-signal and others added 29 commits April 15, 2021 12:07
Instead of trying to keep track of changes as we go and hope that lines
up with reality, now we just write all of our changes and do another
diff at the end to build our insert/delete set. Nice and simple.
@mydickassbusiness
mydickassbusiness changed the base branch from master to moxie/disappearing_messages September 10, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.