Skip to content

Make Cursor an iterator#995

Merged
methane merged 5 commits intoPyMySQL:mainfrom
sanchezg:sanchezg/feat/cursor-as-iterator
May 23, 2023
Merged

Make Cursor an iterator#995
methane merged 5 commits intoPyMySQL:mainfrom
sanchezg:sanchezg/feat/cursor-as-iterator

Conversation

@sanchezg
Copy link
Copy Markdown
Contributor

@sanchezg sanchezg commented Aug 3, 2021

Please check #992

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 3, 2021

This pull request introduces 2 alerts when merging db640e4 into f0091e0 - view on LGTM.com

new alerts:

  • 2 for Iterator does not return self from `__iter__` method

Comment thread pymysql/cursors.py Outdated
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 12, 2021

This pull request introduces 2 alerts when merging 0a16347 into eba874b - view on LGTM.com

new alerts:

  • 2 for Iterator does not return self from `__iter__` method

@methane
Copy link
Copy Markdown
Member

methane commented Aug 13, 2021

As LGTM.com reports, you need to fix SSCursor and SSDictCursor too.

@methane methane changed the title [Issue] Make Cursor an iterator Make Cursor an iterator May 23, 2023
@methane methane linked an issue May 23, 2023 that may be closed by this pull request
@methane methane merged commit a6f53db into PyMySQL:main May 23, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cursor is not an Iterator

2 participants