Problem/Motivation

GraphQL 5.0.0-rc1 has been released, let's add support for it.

Issue fork graphql_address-3589522

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

This is going to be challenging because we have no automated tests.

pfrenssen opened merge request !15

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Title: Support GraphQL 5 » [PP-1] Support GraphQL 5
Status: Active » Postponed
Related issues: +#3590338: Add test coverage

100% correct about needing tests.

Postponing on #3590338: Add test coverage

Thank you for both of these tickets.

czigor’s picture

czigor commented
Status: Postponed » Reviewed & tested by the community

I reviewed the code, it looks good to me. There's only a minor change in the resolvers. The rest is adding tests.

Would be nice to get this in asap since sites having a publicly available graphql api are affected by the vendor library security issue.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Postponed

I'm not going to commit this big of a change without a test suite, stand by, that should be forthcoming today.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Postponed » Needs work

Needs a local rebase, sorry, might be a clash with the few tests that were added here. If the existing tests pass with this change I'll cut a new major version with it.