Problem/Motivation

The schema for the additional properties of the `addtoany_block` and `addtoany_follow_block` blocks is not defined, resulting in schema validation errors.

Steps to reproduce

Configure one of the blocks, and examine your configuration with the config_inspector (or some other config validators), and see issues about "link_url", "link_title", "buttons_size" and "addtoany_html"

Proposed resolution

Define the schema.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 with patch.png153.46 KBkenyoowen
#7 without patch.png178.37 KBkenyoowen
#2 3383459-block-schema.patch884 bytesadam-vessey

Issue fork addtoany-3383459

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

adam-vessey created an issue. See original summary.

adam-vessey’s picture

adam-vessey commented
StatusFileSize
new 3383459-block-schema.patch884 bytes

Thinking something like this should do the trick?

keshavv’s picture

keshavv commented
Status: Active » Needs review

elber made their first commit to this issue’s fork.

elber opened merge request !18

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

Hi I added a change to fix the error in module schema.

I saw it using config_inspector module.

Steps to reproduce

Enable config Inspector and AddToAny Share Buttons modules

go to admin -> reports -> config inpector

And then you should see an error in module schema.

Apply change in the MR.

Go back to module scheme in config_inspector.

No error messages is showed.

kenyoowen’s picture

kenyoowen commented
StatusFileSize
new without patch.png178.37 KB
new with patch.png153.46 KB

Hi elber

I reproduced the error, tested the MR!18, and confirmed that the error in Addtoany at the config inspector was resolved. Please see the screenshots attached.

For your review.
Thank you.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs review » Reviewed & tested by the community

Following the previously comment I think it can be move to RTBC, because it already was revised.

micropat’s picture

micropat commented
Status: Reviewed & tested by the community » Fixed

Fixed in the latest releases.

Validators may balk at the uri type but it's actually valid.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.