Skip to content

fix: conda_install issue with newer conda - #957

Merged
henryiii merged 6 commits into
wntrblm:mainfrom
henryiii:henryiii/fix/conda-install
May 1, 2025
Merged

fix: conda_install issue with newer conda#957
henryiii merged 6 commits into
wntrblm:mainfrom
henryiii:henryiii/fix/conda-install

Conversation

@henryiii

@henryiii henryiii commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

Fix #951.

@henryiii
henryiii force-pushed the henryiii/fix/conda-install branch 2 times, most recently from 67b8d68 to 51709b9 Compare April 30, 2025 19:45
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiii force-pushed the henryiii/fix/conda-install branch from 51709b9 to bab6e2a Compare April 30, 2025 20:04
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title tests: add symbol to conda install fix: conda_install issue with newer conda Apr 30, 2025
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiii force-pushed the henryiii/fix/conda-install branch from 4ea39cc to 18dd1f1 Compare May 1, 2025 03:37
@henryiii

henryiii commented May 1, 2025

Copy link
Copy Markdown
Collaborator Author

I don't understand why this fails on Windows. This is supposed to be supported on Windows without extra escaping as far as I can tell: subprocess.run(["pip", "install", "numpy<2"]), but it seems like that's pretty much what's failing here. And adding quotes causes modern Conda to error out due to the quotes making it through.

@henryiii
henryiii force-pushed the henryiii/fix/conda-install branch from 9cf02b0 to a35c5cf Compare May 1, 2025 07:04
@henryiii
henryiii marked this pull request as ready for review May 1, 2025 07:05
@henryiii

henryiii commented May 1, 2025

Copy link
Copy Markdown
Collaborator Author

This is strictly better on Unix, and Windows just does the same thing (which works on older Conda's, and hopefully mambas).

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiii force-pushed the henryiii/fix/conda-install branch from a35c5cf to f0aeb09 Compare May 1, 2025 14:21
@henryiii
henryiii merged commit e0b5e33 into wntrblm:main May 1, 2025
@henryiii
henryiii deleted the henryiii/fix/conda-install branch May 1, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

session.conda_install fails when specifying min/max version with newer conda

1 participant