fix: move wrangler to peer dependencies - #15080
Conversation
🦋 Changeset detectedLatest commit: 65c928d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| @cloudflare/kv-asset-handler | trusted-with-provenance | none |
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| undici | provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
| "peerDependencies": { | ||
| "astro": "^6.0.0-alpha.0" | ||
| "astro": "^6.0.0-alpha.0", | ||
| "wrangler": "^4.53.0" |
There was a problem hiding this comment.
Would it make sense to use a wider semver range here. @ascorbic do you have any recommendation, what would be the minimal version we need?
There was a problem hiding this comment.
Yes, keep it wide and let the Vite plugin choose the right version
alexanderniebuhr
left a comment
There was a problem hiding this comment.
@gameroman Thanks for this contribution. I agree that we should move wrangler to be a peerDependency. I left some comments for your to consider. :)
ematipico
left a comment
There was a problem hiding this comment.
The changeset needs to change
ematipico
left a comment
There was a problem hiding this comment.
Looks good to me!
@sarah11918, do we need to do something, docs-wise?
sarah11918
left a comment
There was a problem hiding this comment.
@ematipico I assume we're good re: docs here since it doesn't look like anything is required for the user to do! There's already a big Cloudflare docs PR open, so as long as @ascorbic makes sure that anything here is reflected there as needed, I think this can merge fine on its own!
Co-authored-by: Alexander Niebuhr <alexander@nbhr.io>
Co-authored-by: Matt Kane <m@mk.gg>
Co-authored-by: Matt Kane <m@mk.gg>
Changes
Move wrangler to peer dependencies
Testing
Existing tests should pass
Docs
Not necessary