fix(compiler-core): correct filter rewrite recursion by alentide · Pull Request #14959 · vuejs/core

alentide · 2026-06-14T06:12:20Z

In rewriteFilter, the branch handling COMPOUND_EXPRESSION children recursively calls rewriteFilter(node...) instead of rewriteFilter(child...), so the function would never make progress if that branch were reached.

Summary by CodeRabbit

Bug Fixes
- Fixed a compiler bug where filters were not correctly processed in nested expressions. Filters will now be properly applied to complex nested expression structures.

coderabbitai · 2026-06-14T06:12:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9fc99792-2b80-47bd-bd26-90a6132699c0

📥 Commits

Reviewing files that changed from the base of the PR and between 478e3e8 and 9bdeb7c.

📒 Files selected for processing (1)

packages/compiler-core/src/compat/transformFilter.ts

📝 Walkthrough

Walkthrough

In rewriteFilter, the COMPOUND_EXPRESSION branch was recursively calling rewriteFilter(node, ...) (the parent) instead of rewriteFilter(child, ...). The fix changes the argument to child so the traversal descends into nested expressions correctly.

Changes

Filter Rewrite Recursion Fix

Layer / File(s)	Summary
Fix rewriteFilter recursion target `packages/compiler-core/src/compat/transformFilter.ts`	The recursive call in the `COMPOUND_EXPRESSION` branch is corrected from `rewriteFilter(node, ...)` to `rewriteFilter(child, ...)`, ensuring nested expression structures are traversed rather than the parent node being re-processed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hopped through nested trees,
But kept returning to the leaves above.
One word changed — now child, not node —
And filters flowed as they should.
🐇✨ Down the branches, finally free!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary fix in the changeset: correcting a recursion bug in the filter rewrite functionality.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-14T06:13:26Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	106 kB	40.2 kB	36.1 kB
vue.global.prod.js	164 kB	60.2 kB	53.5 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	48.8 kB	19 kB	17.4 kB
createApp	56.9 kB	22 kB	20.1 kB
createSSRApp	61.2 kB	23.8 kB	21.7 kB
defineCustomElement	63.1 kB	23.9 kB	21.8 kB
overall	71.7 kB	27.4 kB	25 kB

pkg-pr-new · 2026-06-14T06:13:31Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14959

npm i https://pkg.pr.new/@vue/compiler-core@14959

yarn add https://pkg.pr.new/@vue/compiler-core@14959.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14959

npm i https://pkg.pr.new/@vue/compiler-dom@14959

yarn add https://pkg.pr.new/@vue/compiler-dom@14959.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14959

npm i https://pkg.pr.new/@vue/compiler-sfc@14959

yarn add https://pkg.pr.new/@vue/compiler-sfc@14959.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14959

npm i https://pkg.pr.new/@vue/compiler-ssr@14959

yarn add https://pkg.pr.new/@vue/compiler-ssr@14959.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14959

npm i https://pkg.pr.new/@vue/reactivity@14959

yarn add https://pkg.pr.new/@vue/reactivity@14959.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14959

npm i https://pkg.pr.new/@vue/runtime-core@14959

yarn add https://pkg.pr.new/@vue/runtime-core@14959.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14959

npm i https://pkg.pr.new/@vue/runtime-dom@14959

yarn add https://pkg.pr.new/@vue/runtime-dom@14959.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14959

npm i https://pkg.pr.new/@vue/server-renderer@14959

yarn add https://pkg.pr.new/@vue/server-renderer@14959.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14959

npm i https://pkg.pr.new/@vue/shared@14959

yarn add https://pkg.pr.new/@vue/shared@14959.tgz

vue

pnpm add https://pkg.pr.new/vue@14959

npm i https://pkg.pr.new/vue@14959

yarn add https://pkg.pr.new/vue@14959.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14959

npm i https://pkg.pr.new/@vue/compat@14959

yarn add https://pkg.pr.new/@vue/compat@14959.tgz

commit: 9bdeb7c

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [vue](https://vuejs.org/) ([source](https://github.com/vuejs/core)) | [`3.5.38` → `3.5.39`](https://renovatebot.com/diffs/npm/vue/3.5.38/3.5.39) | ![age](https://developer.mend.io/api/mc/badges/age/npm/vue/3.5.39?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vue/3.5.38/3.5.39?slim=true) | --- ### Release Notes <details> <summary>vuejs/core (vue)</summary> ### [`v3.5.39`](https://github.com/vuejs/core/blob/HEAD/CHANGELOG.md#3539-2026-06-25) [Compare Source](vuejs/core@v3.5.38...v3.5.39) ##### Bug Fixes - **compiler-core:** correct filter rewrite recursion ([#14959](vuejs/core#14959)) ([be7ce31](vuejs/core@be7ce31)) - **hydration:** force patch dynamic props when hydrating ([#9083](vuejs/core#9083)) ([024cf06](vuejs/core@024cf06)), closes [#9033](vuejs/core#9033) - **hydration:** respect data-allow-mismatch on conditional branches ([#12801](vuejs/core#12801)) ([164af63](vuejs/core@164af63)), closes [#12782](vuejs/core#12782) - **reactivity:** avoid triggering effects when set fails ([#14964](vuejs/core#14964)) ([e450973](vuejs/core@e450973)) - **runtime-core:** handle non-isomorphic block element update ([#15002](vuejs/core#15002)) ([932ddd0](vuejs/core@932ddd0)), closes [#6385](vuejs/core#6385) - **runtime-core:** normalize function children for elements and Teleport ([#9108](vuejs/core#9108)) ([2f374cd](vuejs/core@2f374cd)), closes [#9107](vuejs/core#9107) - **runtime-core:** pause tracking when invoking function refs ([#14985](vuejs/core#14985)) ([3ac052b](vuejs/core@3ac052b)) - **runtime-core:** preserve once event listener name ([#8341](vuejs/core#8341)) ([87b73b6](vuejs/core@87b73b6)), closes [#8342](vuejs/core#8342) - **runtime-dom:** preserve option modifier event names ([#8338](vuejs/core#8338)) ([4b659e6](vuejs/core@4b659e6)), closes [#8334](vuejs/core#8334) - **ssr:** dedupe inherited scope ids during vnode rendering ([#15005](vuejs/core#15005)) ([027da6b](vuejs/core@027da6b)), closes [#12159](vuejs/core#12159) [#12175](vuejs/core#12175) - **ssr:** resolve nested async teleport content ([#9431](vuejs/core#9431)) ([31d0f23](vuejs/core@31d0f23)), closes [#6207](vuejs/core#6207) - **teleport:** handle teleport unmount edge case ([#12705](vuejs/core#12705)) ([671997a](vuejs/core@671997a)), closes [#12702](vuejs/core#12702) - **types:** support named tuple emits ([#12676](vuejs/core#12676)) ([232f402](vuejs/core@232f402)), closes [#12673](vuejs/core#12673) - **types:** validate defineModel defaults ([#14968](vuejs/core#14968)) ([747f57e](vuejs/core@747f57e)), closes [#14966](vuejs/core#14966) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Co-authored-by: leuwen-lc <leuwen-lc@noreply.codeberg.org> Reviewed-on: https://codeberg.org/leuwen-lc/rhdemo/pulls/180

fix(compiler-core): correct filter rewrite recursion

9bdeb7c

edison1105 added ready to merge The PR is ready to be merged. scope: compiler labels Jun 25, 2026

edison1105 merged commit be7ce31 into vuejs:main Jun 25, 2026
14 checks passed

Navigation Menu

Uh oh!

Uh oh!

fix(compiler-core): correct filter rewrite recursion - #14959

fix(compiler-core): correct filter rewrite recursion#14959
edison1105 merged 1 commit into
vuejs:mainfrom
alentide:fix-compiler-filter-recursion

alentide commented Jun 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 14, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

pkg-pr-new Bot commented Jun 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

alentide commented Jun 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 14, 2026

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new Bot commented Jun 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alentide commented Jun 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 14, 2026 •

edited

Loading