fix(preset-icons): support captital letters in className#4149
fix(preset-icons): support captital letters in className#4149zyyv merged 1 commit intounocss:mainfrom
Conversation
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
We keep the lowercase syntax in all regular expressions by default, and why don't you use lowercase syntax anymore? The capitalized syntax is weird when connected after |
|
I don't think so. First of all, the DOM's className supports uppercase characters, so there should be the freedom to use uppercase characters. Secondly, for some technical terms, uppercase characters are necessary, such as ECS, IBM, KFC, Apple, which makes it more intuitive. Thirdly, the SVG materials provided by designers also use uppercase characters, and to maintain consistency, the icons need to use uppercase characters as well. Isn't it a better choice to gain greater freedom with just a little change? |
|
“We keep the lowercase syntax in all regular expressions by default” |
@shenjunjian I actually don't want to see any breakthroughs in this area, as it would create an update burden, such as We get icons from iconify, and I think we should follow the upstream naming conventions. |
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
|
commit: |
close: #4148
support captital letter in className