Skip to content

Tree-shake un-included elements in array pattern#6100

Merged
lukastaegert merged 2 commits intomasterfrom
fix/6099
Sep 13, 2025
Merged

Tree-shake un-included elements in array pattern#6100
lukastaegert merged 2 commits intomasterfrom
fix/6099

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #6099

Description

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Sep 12, 2025 9:05am

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 11, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/6099

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-f17q9529s-rollup-js.vercel.app/repl/?pr=6100

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 11, 2025

Performance report

  • BUILD: 6871ms, 817 MB
    • initialize: 0ms, 25 MB
    • generate module graph: 2559ms, 631 MB
      • generate ast: 1370ms, 624 MB
    • sort and bind modules: 380ms, 686 MB
    • mark included statements: 3917ms, 817 MB
      • treeshaking pass 1: 2311ms, 814 MB
      • treeshaking pass 2: 452ms, 843 MB (+4%)
      • treeshaking pass 3: 390ms, 818 MB
      • treeshaking pass 4: 377ms, 827 MB (+3%)
      • treeshaking pass 5: 373ms, 817 MB
  • GENERATE: 850ms (+94ms, +12.5%), 922 MB (-4%)
    • initialize render: 0ms, 906 MB (-3%)
    • generate chunks: 46ms (-37ms, -44.5%), 902 MB (-6%)
      • optimize chunks: 0ms, 924 MB (-3%)
    • render chunks: 710ms (+22ms, +3.1%), 896 MB (-2%)
    • transform chunks: 18ms, 922 MB (-4%)
    • generate bundle: 0ms, 922 MB (-4%)

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (efc7545) to head (bf33035).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6100   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         271      271           
  Lines       10624    10632    +8     
  Branches     2841     2843    +2     
=======================================
+ Hits        10490    10498    +8     
  Misses         89       89           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks a lot!

@lukastaegert lukastaegert added this pull request to the merge queue Sep 13, 2025
Merged via the queue into master with commit bbc952c Sep 13, 2025
195 of 207 checks passed
@lukastaegert lukastaegert deleted the fix/6099 branch September 13, 2025 05:06
@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.50.2-2. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.50.2-2 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.50.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR: The symbol "XXX" has already been declared

2 participants