add pattern to sunburst - #6622
Merged
Merged
Conversation
1st version, setting the attributes & defaults in the extended schema, and rework styleOne, in case a marker point is set
issue : check if fgcolor is an array
Contributor
|
Wow, this would be another really nice feature. Please collect & update the baseline from here. I just noticed a bug i.e. by clicking the sunburst, patterns disappear. |
Contributor
Author
|
I created the baseline locally in the browser via > Tabs.snapshot()
Is there another way to create these locally?
Thanks, I will dig into the disappearing patterns when clicking.
…On Thu, 1 Jun 2023 at 18:30, Mojtaba Samimi ***@***.***> wrote:
Wow, this would be another really nice feature.
Thank you!
Please collect & update the baseline from here
<https://app.circleci.com/pipelines/github/plotly/plotly.js/8734/workflows/5b70b21d-e190-4f2c-8128-3b46508e5781/jobs/192601/artifacts>
.
I just noticed a bug i.e. by clicking the sunburst, patterns disappear.
—
Reply to this email directly, view it on GitHub
<#6622 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYGOP3J4EDN7DDHFXOUIQLXJC7R7ANCNFSM6AAAAAAYWXEMKM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
+ update baseline png
Contributor
|
It is fine to pick the baselines from CircleCI. |
archmoj
reviewed
Jun 1, 2023
Contributor
|
Nicely done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up on #6601 and #6619 where pattern was added to pie & funnelarea.