Skip to content

Add --strict option to custom bundle - #6557

Merged
archmoj merged 6 commits into
plotly:masterfrom
CallumNZ:custom-bundle-strict
Apr 17, 2023
Merged

Add --strict option to custom bundle#6557
archmoj merged 6 commits into
plotly:masterfrom
CallumNZ:custom-bundle-strict

Conversation

@CallumNZ

@CallumNZ CallumNZ commented Apr 8, 2023

Copy link
Copy Markdown
Contributor

Reference: #6496

Changes:

  • Add --strict option to custom bundle command so that strict traces can be used in a custom bundle.

Comment thread tasks/partial_bundle.js Outdated
@archmoj archmoj added the community community contribution label Apr 13, 2023
@archmoj

archmoj commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Please also add draftlogs/6557_add.md as described here.
Thank you!

CallumNZ added a commit to CallumNZ/plotly.js that referenced this pull request Apr 14, 2023
CallumNZ added a commit to CallumNZ/plotly.js that referenced this pull request Apr 14, 2023
@CallumNZ
CallumNZ force-pushed the custom-bundle-strict branch from 4c00d9c to ae97664 Compare April 14, 2023 00:56
@CallumNZ
CallumNZ force-pushed the custom-bundle-strict branch from ae97664 to 5fd35d0 Compare April 14, 2023 00:58
@archmoj archmoj added the feature something new label Apr 14, 2023
Comment thread draftlogs/6557_add.md Outdated
Comment thread tasks/partial_bundle.js Outdated
Comment thread tasks/partial_bundle.js Outdated
@archmoj

archmoj commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Thanks for the improvements 🥇
Please commit my suggestions above and this should be ready to go.

CallumNZ and others added 3 commits April 15, 2023 09:54
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
@archmoj

archmoj commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

💃

@archmoj
archmoj merged commit 21d09a6 into plotly:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community community contribution feature something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants