fix for incorrect final position when dragging legend - #6528
Merged
Conversation
archmoj
reviewed
Mar 17, 2023
legendObj._height and legendObj._width are used for positioning the element at the outset, so it seems appropriate to use them again here
archmoj
reviewed
Mar 17, 2023
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
When
layout.legend.xanchor !== 'left'orlayout.legend.yanchor !== 'top', the draggable legend enabled by settingconfig.editable=trueorconfig.edits.legendPosition=truedoes not work properly.During the drag, the position updates correctly, but on release it snaps to a new position. This is because the width and height of the legend are not taken into account in the calculation of
dragElement.align(...), with the second argumentdv=0for both xf and yf.This PR addresses that by including the width and height of the legend in the calculation.
Examples
To reproduce the bug, show either of these figures and drag the legend:
{ "data": [ { "name":"A very long name indeed (though it could be longer)", "x":[1,2,3], "y":[2,3,4], "type":"scatter" } ], "layout": { "showlegend": true, "legend": { "x": 0.5, "y": 0.5, "xanchor": "center", "yanchor": "middle" } }, "config": { "edits": {"legendPosition": true} } }{ "data": [ { "name":"A very long name indeed (though it could be longer)", "x":[1,2,3], "y":[2,3,4], "type":"scatter" } ], "layout": { "showlegend": true, "legend": { "x": 0.5, "y": 0.5, "xanchor": "left", "yanchor": "bottom" } }, "config": { "edits": {"legendPosition": true} } }