Skip to content

disable interactions for slider when staticPlot is true - #6393

Merged
archmoj merged 2 commits into
masterfrom
fix6392-static-slider
Dec 13, 2022
Merged

disable interactions for slider when staticPlot is true#6393
archmoj merged 2 commits into
masterfrom
fix6392-static-slider

Conversation

@archmoj

@archmoj archmoj commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Fixes #6392.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Dec 12, 2022

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 with a changelog entry

@archmoj
archmoj merged commit 0e2b249 into master Dec 13, 2022
@archmoj
archmoj deleted the fix6392-static-slider branch December 13, 2022 00:10
@josephernest

Copy link
Copy Markdown

Thanks @archmoj, this is fast!

Is there a distribution version plotly-testing.min.js that is ready-to-use and contains these changes?

(I don't have the building tooling installed here to produce it)

@archmoj

archmoj commented Dec 13, 2022

Copy link
Copy Markdown
Contributor Author

@josephernest
You could use v2.16.5 release now.

@josephernest

Copy link
Copy Markdown

Thank you @archmoj! Is the main file I should use this one? plotly.js-2.16.5\dist\plotly.min.js?
PS: I tried <script src="proxy.php?url=https%3A%2F%2Fcdn.plot.ly%2Fplotly-2.16.5.js"></script> and it works from cdn!

@josephernest

josephernest commented Dec 13, 2022

Copy link
Copy Markdown

Note @archmoj: it seems to work, but a small last thing: the mouse cursor on hover of the sliders still change to ew-resize , ie "movable" cursor, and it should not if staticPlot = true. Maybe for 2.16.5.2 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

static slider

3 participants