Skip to content

doc,src,test: fix typos - #58477

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
noritaka1166:fix-typos
May 28, 2025
Merged

doc,src,test: fix typos#58477
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
noritaka1166:fix-typos

Conversation

@noritaka1166

@noritaka1166 noritaka1166 commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix typos

  • Snapsnot β†’ Snapshot
  • maxumum β†’ maximum
  • memeber β†’ member
  • acutually β†’ actually
  • processsing β†’ processing
  • sesson β†’ session
  • receied β†’ received

@nodejs-github-bot

nodejs-github-bot commented May 27, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 27, 2025
@noritaka1166 noritaka1166 changed the title chore: fix typos doc: fix typos May 27, 2025
@noritaka1166 noritaka1166 changed the title doc: fix typos doc,src,test: fix typos May 27, 2025
daeyeon
daeyeon reviewed May 27, 2025
View reviewed changes
Comment thread src/quic/session.h Outdated
@codecov

codecov Bot commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 90.20%. Comparing base (bbc0593) to head (1d376f3).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58477      +/-   ##
==========================================
- Coverage   90.20%   90.20%   -0.01%     
==========================================
  Files         635      635              
  Lines      187344   187344              
  Branches    36792    36788       -4     
==========================================
- Hits       168996   168991       -5     
- Misses      11090    11128      +38     
+ Partials     7258     7225      -33
Files with missing lines Coverage Ξ”
src/node_platform.h 91.66% <ΓΈ> (ΓΈ)

... and 42 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JakobJingleheimer
JakobJingleheimer approved these changes May 27, 2025
View reviewed changes

@JakobJingleheimer JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please update the first commit message to reflect the typo fixes? That is what will be used when this lands.

I think src is not the correct prefix perhaps doc:

@noritaka1166

noritaka1166 commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks! Could you please update the first commit message to reflect the typo fixes? That is what will be used when this lands.

think src is not the correct prefix perhaps doc:

@JakobJingleheimer
Done!

@JakobJingleheimer

JakobJingleheimer commented May 27, 2025

Copy link
Copy Markdown
Member

Thanks! Could you please update the first commit message to reflect the typo fixes? That is what will be used when this lands.

think src is not the correct prefix perhaps doc:

@JakobJingleheimer

Done!

It looks like you updated the PR title but not the commit messages (lots of people do this). Node's merge tooling does not use the PR title.

@noritaka1166 noritaka1166 changed the title doc,src,test: fix typos doc: fix typos May 27, 2025
@noritaka1166 noritaka1166 changed the title doc: fix typos doc,src,test: fix typos May 27, 2025
@noritaka1166

noritaka1166 commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks! Could you please update the first commit message to reflect the typo fixes? That is what will be used when this lands.

think src is not the correct prefix perhaps doc:

@JakobJingleheimer
Done!

It looks like you updated the PR title but not the commit messages (lots of people do this). Node's merge tooling does not use the PR title.

@JakobJingleheimer
I tried, is this correct?

@JakobJingleheimer

JakobJingleheimer commented May 27, 2025

Copy link
Copy Markdown
Member

I think it worked!

RaisinTen
RaisinTen reviewed May 27, 2025
View reviewed changes
Comment thread test/fixtures/snapshot/typescript.js Outdated
RaisinTen
RaisinTen approved these changes May 27, 2025
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 27, 2025
@bjohansebas bjohansebas removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 27, 2025
@JakobJingleheimer JakobJingleheimer added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 28, 2025
@nodejs-github-bot

nodejs-github-bot commented May 28, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/58477
βœ”  Done loading data for nodejs/node/pull/58477
----------------------------------- PR info ------------------------------------
Title      doc,src,test: fix typos (#58477)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     noritaka1166:fix-typos -> nodejs:main
Labels     c++, lib / src, fast-track, author ready, needs-ci, commit-queue-squash
Commits    4
 - doc,src,test: fix typos
 - src: fix typos in quic/session.h
 - src: remove space
 - test: revert fix typo
Committers 1
 - Noritaka Kobayashi <arukimedesu1166777@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/58477
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58477
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Tue, 27 May 2025 03:36:13 GMT
   βœ”  Approvals: 7
   βœ”  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/58477#pullrequestreview-2869829018
   βœ”  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/58477#pullrequestreview-2871019828
   βœ”  - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/58477#pullrequestreview-2871215848
   βœ”  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/58477#pullrequestreview-2871303916
   βœ”  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/58477#pullrequestreview-2871914509
   βœ”  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58477#pullrequestreview-2872372025
   βœ”  - Dario Piotrowicz (@dario-piotrowicz): https://github.com/nodejs/node/pull/58477#pullrequestreview-2872987502
   β„Ή  This PR is being fast-tracked
   βœ”  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   βœ”  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/15289132632

@RaisinTen RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67161/

@RaisinTen RaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 28, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 3877800 into nodejs:main May 28, 2025
@nodejs-github-bot

nodejs-github-bot commented May 28, 2025

Copy link
Copy Markdown
Collaborator

Landed in 3877800

@noritaka1166
noritaka1166 deleted the fix-typos branch May 28, 2025 10:02
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label May 28, 2025
@github-actions github-actions Bot mentioned this pull request Jun 8, 2025
Merged
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Merged
@marco-ippolito marco-ippolito mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daeyeon daeyeon daeyeon left review comments
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@pmarchini pmarchini pmarchini approved these changes
@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.