fix(router): make currentSnapshot required in CanMatchFn - #67452
Closed
atscott wants to merge 3 commits into
Closed
Conversation
atscott
force-pushed
the
requiresnapshotcanmatch
branch
2 times, most recently
from
March 5, 2026 00:09
a002c6b to
766e493
Compare
it was only optional to avoid a breaking change in a minor BREAKING CHANGE: The `currentSnapshot` parameter in `CanMatchFn` and the `canMatch` method of the `CanMatch` interface is now required. While this was already the behavior of the Router at runtime, existing class implementations of `CanMatch` must now include the third argument to satisfy the interface.
atscott
force-pushed
the
requiresnapshotcanmatch
branch
from
March 31, 2026 21:54
e6f9930 to
ee5115e
Compare
the third partial match snapshot parameter is now required in the types since the Router always providers it
atscott
force-pushed
the
requiresnapshotcanmatch
branch
from
March 31, 2026 22:03
ee5115e to
504f25c
Compare
JeanMeche
approved these changes
Apr 1, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it was only optional to avoid a breaking change in a minor
BREAKING CHANGE: The
currentSnapshotparameter inCanMatchFnand thecanMatchmethod of theCanMatchinterface is now required. While this was already the behavior of the Router at runtime, existing class implementations ofCanMatchmust now include the third argument to satisfy the interface.