feat(core): support default value in resource() - #59655
Closed
alxhub wants to merge 1 commit into
Closed
Conversation
pullapprove
Bot
requested review from
kirjs,
pkozlowski-opensource and
thePunderWoman
January 21, 2025 21:29
alfaproject
reviewed
Jan 21, 2025
alxhub
force-pushed
the
experimental/resource/default-value
branch
from
January 21, 2025 23:12
14c1a0e to
9c705d5
Compare
resource()
AndrewKushnir
approved these changes
Jan 22, 2025
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
pkozlowski-opensource
approved these changes
Jan 22, 2025
pkozlowski-opensource
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
kirjs
reviewed
Jan 22, 2025
kirjs
approved these changes
Jan 22, 2025
Before `resource()` resolves, its value is in an unknown state. By default it returns `undefined` in these scenarios, so the type of `.value()` includes `undefined`. This commit adds a `defaultValue` option to `resource()` and `rxResource()` which overrides this default. When provided, an unresolved resource will return this value instead of `undefined`, which simplifies the typing of `.value()`.
alxhub
force-pushed
the
experimental/resource/default-value
branch
from
January 23, 2025 15:54
9c705d5 to
14183ec
Compare
Member
|
This PR was merged into the repository by commit 1685164. The changes were merged into the following branches: main |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Before `resource()` resolves, its value is in an unknown state. By default it returns `undefined` in these scenarios, so the type of `.value()` includes `undefined`. This commit adds a `defaultValue` option to `resource()` and `rxResource()` which overrides this default. When provided, an unresolved resource will return this value instead of `undefined`, which simplifies the typing of `.value()`. PR Close angular#59655
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(core): support default value in
resource()Before
resource()resolves, its value is in an unknown state. By default it returnsundefinedin these scenarios, so the type of.value()includesundefined.This commit adds a
defaultValueoption toresource()andrxResource()which overrides this default. When provided, an unresolved resource will return this value instead ofundefined, which simplifies the typing of.value().