Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: validatedpatterns/common
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: validatedpatterns/common
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 7 files changed
  • 1 contributor

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    47c5923 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4fceb0d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Allow customizing the clusterGroupChartVersion

    ❯ helm template . --show-only "templates/pattern.yaml"
    ---
    apiVersion: gitops.hybrid-cloud-patterns.io/v1alpha1
    kind: Pattern
    metadata:
      name: release-name
      namespace: openshift-operators
    spec:
      clusterGroupName: default
      gitSpec:
        targetRepo: https://github.com/pattern-clone/mypattern
        targetRevision: main
      multiSourceConfig:
        enabled: false
    
    ❯ helm template .  --show-only "templates/pattern.yaml"  --set main.multiSourceConfig.clusterGroupChartVersion=0.9.\*
    ---
    apiVersion: gitops.hybrid-cloud-patterns.io/v1alpha1
    kind: Pattern
    metadata:
      name: release-name
      namespace: openshift-operators
    spec:
      clusterGroupName: default
      gitSpec:
        targetRepo: https://github.com/pattern-clone/mypattern
        targetRevision: main
      multiSourceConfig:
        enabled: false
        clusterGroupChartVersion: 0.9.*
    mbaldessari committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    08cff4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    003e011 View commit details
    Browse the repository at this point in the history
  3. Drop the chart splitting workflows

    They used to run only for the main branch and this is the v1 branch, but
    let's drop them anyway as they cause quite a bit of confusion.
    mbaldessari committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3331527 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #598 from mbaldessari/v1-operator-install-clusterg…

    …roupversion
    
    v1 operator install clustergroupversion
    mbaldessari authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    06a5879 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Make sure we compare lists with lists when doing a difference

    While this works with older ansible versions (2.15 and before), we
    need to check the difference between two lists and not a list and an
    item. This breaks with ansible 2.16 and onwards
    
    Tested with newer ansible and the vault now unseals correctly.
    mbaldessari committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0123cde View commit details
    Browse the repository at this point in the history
  2. Merge pull request #599 from mbaldessari/v1-unseal-fix

    Make sure we compare lists with lists when doing a difference
    mbaldessari authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1cceddf View commit details
    Browse the repository at this point in the history
Loading