From 84ebd2ff57b70339a3014949c52f7b65a34f746c Mon Sep 17 00:00:00 2001 From: mytsk Date: Fri, 15 Jan 2021 15:17:08 +0100 Subject: [PATCH 1/3] fixed issues in space arrays --- PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 | 26 +++++++++++-------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 b/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 index 8162345..976312e 100644 --- a/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 +++ b/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 @@ -30,31 +30,35 @@ function Get-SOSIDs { } $SIDsResponse = Invoke-RestMethod @SIDCall - $SIDCount = ($SIDsResponse.document.servicesets.serviceset).count - if ($SIDCount -eq $null) {$SIDCount = 1} + $SIDCount = ((($SIDsResponse.document.servicesets.serviceset) | Measure-Object).Count) + if (!$SIDCount) {$SIDCount = 1} [Array] $SSID = $SIDsResponse.document.servicesets.serviceset.properties.ssid [Array] $Name = $SIDsResponse.document.servicesets.serviceset.properties.name + [Array] $Product = $SIDsResponse.document.servicesets.serviceset.properties.productClass [Array] $Alias = $SIDsResponse.document.servicesets.serviceset.properties.alias [Array] $OverallHealth = $SIDsResponse.document.servicesets.serviceset.properties.overallHealth [Array] $SerialNumber = $SIDsResponse.document.servicesets.serviceset.properties.serialNumber - [Array] $CapacityBytes = $SIDsResponse.document.servicesets.serviceset.properties.capacityBytes - [Array] $FreeBytes = $SIDsResponse.document.servicesets.serviceset.properties.freeBytes - [Array] $UserBytes = $SIDsResponse.document.servicesets.serviceset.properties.userBytes - [Array] $DiskBytes = $SIDsResponse.document.servicesets.serviceset.properties.diskBytes + [Array] $CapacityBytes = $SIDsResponse.document.servicesets.serviceset.properties.localCapacityBytes + [Array] $FreeBytes = $SIDsResponse.document.servicesets.serviceset.properties.localFreeBytes + [Array] $UserBytes = $SIDsResponse.document.servicesets.serviceset.properties.localUserBytes + [Array] $DiskBytes = $SIDsResponse.document.servicesets.serviceset.properties.localDiskBytes + [Array] $DedupeRatio = $SIDsResponse.document.servicesets.serviceset.properties.dedupeRatio for ($i = 0; $i -lt $SIDCount; $i++ ){ $row = [PSCustomObject] @{ System = $($SOConnection.Server) - SIDCount = [String] $SIDCount + SIDCount = [String] $SIDCount[$i] SSID = $SSID[$i] Name = $Name[$i] + ProductClass= $Product[$i] Alias = $Alias[$i] OverallHealth = $OverallHealth[$i] SerialNumber = $SerialNumber[$i] - "Capacity(GB)" = ([math]::Round(($CapacityBytes[$i] / 1073741824),2)) - "Free(GB)" = ([math]::Round(($FreeBytes[$i] / 1073741824),2)) - "UserData(GB)" = ([math]::Round(($UserBytes[$i] / 1073741824),2)) - "DiskData(GB)" = ([math]::Round(($DiskBytes[$i] / 1073741824),2)) + "Capacity(GB)" = ([math]::Round(($CapacityBytes[$i] / 1gb),2)) + "Free(GB)" = ([math]::Round(($FreeBytes[$i] / 1gb),2)) + "UserData(GB)" = ([math]::Round(($UserBytes[$i] / 1gb),2)) + "DiskData(GB)" = ([math]::Round(($DiskBytes[$i] / 1gb),2)) + "Dedeup Ratio" = $DedupeRatio[$i] } $SOSIDs += $row } From d19ec059fd8f055d335d14027e58935ea7d9a21b Mon Sep 17 00:00:00 2001 From: mytsk Date: Fri, 15 Jan 2021 15:28:19 +0100 Subject: [PATCH 2/3] minor formating changes --- PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 b/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 index 976312e..5d880e3 100644 --- a/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 +++ b/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 @@ -34,7 +34,7 @@ function Get-SOSIDs { if (!$SIDCount) {$SIDCount = 1} [Array] $SSID = $SIDsResponse.document.servicesets.serviceset.properties.ssid [Array] $Name = $SIDsResponse.document.servicesets.serviceset.properties.name - [Array] $Product = $SIDsResponse.document.servicesets.serviceset.properties.productClass + [Array] $Product = $SIDsResponse.document.servicesets.serviceset.properties.productClass [Array] $Alias = $SIDsResponse.document.servicesets.serviceset.properties.alias [Array] $OverallHealth = $SIDsResponse.document.servicesets.serviceset.properties.overallHealth [Array] $SerialNumber = $SIDsResponse.document.servicesets.serviceset.properties.serialNumber From e93da5ae2121ba49a77a35da091b7c7671d36c94 Mon Sep 17 00:00:00 2001 From: mytsk Date: Fri, 15 Jan 2021 16:55:44 +0100 Subject: [PATCH 3/3] Update Get-SOSIDs.psm1 --- PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 b/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 index 5d880e3..768b273 100644 --- a/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 +++ b/PS-StoreOnce/Functions/Report/Get-SOSIDs.psm1 @@ -68,4 +68,4 @@ function Get-SOSIDs { Return $SOSIDs } } -#endregion +#endregion \ No newline at end of file