Skip to content

filter does not handle dots as expected #212

@oliverkurth

Description

@oliverkurth

The dot (.) in the filter rules is used to match any character. So for example ....foo.bar matches www.foo.bar and www.foo.bar would also match wwwxfooybar. This should be better documented, since it's not what a naive user would expect, and they might accidentally allow or block domains unintentionally. To correctly block/allow www.foo.bar you would need to set www\.foo\.bar.

I would actually prefer it to be simpler. I think fnmatch() could be used instead of regexc().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions