Improve detection of system qcustomplot/qhexedit#2952
Merged
Conversation
Contributor
|
The use of named parameters (i.e. 'NAMES' et al) in the calls to find_library is a good thing. Explicit is better than implicit. I would also point out that this is from Fedora. They have a tendency to name files/packages on their terms ignoring what other distributions might name things. The patch appears to add library names for this reason. Overall, I don't see conflicts. Merge should be okay. |
Member
|
Thanks, @manisandro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch from the Fedora package