fix(secrets): use Promise.allSettled to ensure credential invalidation after all mutations settle

waleedlatif1 · waleedlatif1 · commit 1cb58109e61e · 2026-04-07T18:22:03.000-07:00
diff --git a/apps/sim/app/workspace/[workspaceId]/settings/components/credentials/credentials-manager.tsx b/apps/sim/app/workspace/[workspaceId]/settings/components/credentials/credentials-manager.tsx
@@ -1012,7 +1012,9 @@ export function CredentialsManager() {
         )
       }
 
-      await Promise.all(mutations)
+      const results = await Promise.allSettled(mutations)
+      const firstFailure = results.find((r): r is PromiseRejectedResult => r.status === 'rejected')
+      if (firstFailure) throw firstFailure.reason
 
       setWorkspaceVars(mergedWorkspaceVars)
       setNewWorkspaceRows([createEmptyEnvVar()])

Original file line number	Diff line number	Diff line change
`@@ -1012,7 +1012,9 @@ export function CredentialsManager() {`
`1012`	`1012`	`)`
`1013`	`1013`	`}`
`1014`	`1014`
`1015`		`- await Promise.all(mutations)`
	`1015`	`+ const results = await Promise.allSettled(mutations)`
	`1016`	`+ const firstFailure = results.find((r): r is PromiseRejectedResult => r.status === 'rejected')`
	`1017`	`+ if (firstFailure) throw firstFailure.reason`
`1016`	`1018`
`1017`	`1019`	`setWorkspaceVars(mergedWorkspaceVars)`
`1018`	`1020`	`setNewWorkspaceRows([createEmptyEnvVar()])`