Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: sibStephen/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 1,388 files changed
  • 11 contributors

Commits on Sep 2, 2015

  1. src: fix memory leak in ExternString

    v8 will silently return an empty handle
    which doesn't delete our data if string length is
    above String::kMaxLength
    
    Fixes: #1374
    PR-URL: #2402
    Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
    skomski authored and trevnorris committed Sep 2, 2015
    6 Configuration menu
    Copy the full SHA
    617ee32 View commit details
    Browse the repository at this point in the history
  2. child_process: add callback parameter to .send()

    Add an optional callback parameter to `ChildProcess.prototype.send()`
    that is invoked when the message has been sent.
    
    Juggle the control channel's reference count so that in-flight messages
    keep the event loop (and therefore the process) alive until they have
    been sent.
    
    `ChildProcess.prototype.send()` and `process.send()` used to operate
    synchronously but became asynchronous in commit libuv/libuv@393c1c5
    ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed
    in io.js in commit 07bd05b ("deps: update libuv to 1.2.1").
    
    Fixes: #760
    PR-URL: #2620
    Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
    bnoordhuis authored and trevnorris committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    56d9584 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2015

  1. test: mark eval_messages as flaky

    This test has failed recently during a PR test in Jenkins, for
    reasons seemingly not related to the change in the PR.
    
    PR-URL: #2648
    Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
    orangemocha committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    abbc8db View commit details
    Browse the repository at this point in the history
  2. doc: reorder collaborators by their usernames

    Fixes: #1972
    PR-URL: #2322
    Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
    Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    jbergstroem committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    6ce8f5f View commit details
    Browse the repository at this point in the history
  3. doc: update url doc to account for escaping

    Fixes: #2113
    Ref: 17a379e
    PR-URL: #2605
    Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
    Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: mscdex - Brian White <mscdex@mscdex.net>
    Fishrock123 committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    47e5cf7 View commit details
    Browse the repository at this point in the history
  4. test: refactor to eliminate flaky test

    This retains the key elements of test-child-process-fork-getconnections
    (forks a child process, sends a bunch of sockets, uses getConnections()
    to enumerate them) but contains some code to work around an apparent
    intermittent bug that occurs on OS X where a socket seems to close
    itself unexpectedly.
    
    #2610 was opened for the bug that
    was causing the problem in the first place.
    
    PR-URL: #2609
    Fixes: #1100
    Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    Trott committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    8ca9ea2 View commit details
    Browse the repository at this point in the history
  5. child_process: check execFile and fork args

    Port of joyent/node commits:
    
     * nodejs/node-v0.x-archive@e17c5a7
     * nodejs/node-v0.x-archive@70dafa7
    
    Pull over test-child-process-spawn-typeerror.js from v0.12, replacing
    the existing test in master. The new test includes a broader set of
    tests on the various arg choices and throws.
    
    Reviewed-By: trevnorris - Trevor Norris <trevnorris@nodejs.org>
    Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: thefourtheye - Sakthipriyan Vairamani
    PR-URL: #2667
    Fixes: #2515
    jasnell committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    107cbd6 View commit details
    Browse the repository at this point in the history
  6. build: add --enable-asan with builtin leakcheck

    PR-URL: #2376
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    skomski authored and indutny committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    4a1b519 View commit details
    Browse the repository at this point in the history
  7. events,lib: don't require EE#listenerCount()

    Now parts of our public and public-ish APIs fall back to old-style
    listenerCount() if the emitter does not have a listenerCount function.
    
    Fixes: #2655
    Refs: 8f58fb9
    
    PR-URL: #2661
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Fishrock123 committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    b513a33 View commit details
    Browse the repository at this point in the history
  8. deps: upgrade V8 to 4.5.103.24

    Upgrade to the latest branch-head for V8 4.5. For the full commit log see
    https://github.com/v8/v8-git-mirror/commits/4.5.103.24
    
    PR-URL: #2509
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    1134188 View commit details
    Browse the repository at this point in the history
  9. src: apply debug force load fixups from 41e63fb

    Apply the src/node_contextify.cc and lib/module.js fixups from @bnoordhuis
    41e63fb
    
    PR-URL: #2509
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    a7392ff View commit details
    Browse the repository at this point in the history
  10. contextify: ignore getters during initialization

    The `context_` is not initialized until the `CreateV8Context` will
    return. Make sure that it will be empty (by moving away initialization
    from constructor) at start, and ignore getter callbacks until it will
    have some value.
    
    PR-URL: #2091
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    indutny authored and ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    709ed15 View commit details
    Browse the repository at this point in the history
  11. test: fix test-repl-tab-complete.js for V8 4.5

    The list of Array properties needed to be updated to match the new ones added
    in V8 4.5.
    
    PR-URL: #2509
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    06f38de View commit details
    Browse the repository at this point in the history
  12. src: enable v8 deprecation warnings and fix them

    Turn on V8 API deprecation warnings.  Fix up the no-arg Isolate::New()
    calls in src/node.cc and src/debug-agent.cc.
    
    PR-URL: #2091
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    39aa573 View commit details
    Browse the repository at this point in the history
  13. src: replace usage of v8::Handle with v8::Local

    v8::Handle is deprecated: https://codereview.chromium.org/1224623004
    
    PR-URL: #2202
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    targos authored and ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    d08bb97 View commit details
    Browse the repository at this point in the history
  14. src: enable vector ics on arm again

    The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6
    no longer manifests with (at least) 4.5.103.20.
    
    [1] See https://code.google.com/p/v8/issues/detail?id=4338
    
    PR-URL: #2509
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    564e214 View commit details
    Browse the repository at this point in the history
  15. src: re-enable fast math on arm

    Ref: #1376
    Ref: #1398
    Issue fixed in V8: https://chromium.googlesource.com/v8/v8/+/81703350bbb9923d211fe5b79e90bd458b0916e2
    V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019
    
    PR-URL: #2592
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    targos authored and ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    074315f View commit details
    Browse the repository at this point in the history
  16. deps: upgrade V8 to 4.5.103.30

    Pick up v8/v8@f9a0a16
    Commit log at https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5
    
    PR-URL: #2632
    Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
    Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
    ofrobots committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    64beab0 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2015

  1. test: fix use of common before required

    PR-URL: #2685
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    rvagg committed Sep 4, 2015
    Configuration menu
    Copy the full SHA
    fc66eed View commit details
    Browse the repository at this point in the history
  2. buffer: SlowBuffer only accept valid numeric values

    Fixes a regression that appeared with the new Buffer implementation in v3.
    Without this change, calling the SlowBuffer constructor with something else
    than a number would abort on the C++ side. This makes sure that the length
    argument is coerced to number or is 0.
    
    Fixes: #2634
    PR-URL: #2635
    Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
    targos committed Sep 4, 2015
    Configuration menu
    Copy the full SHA
    eefe14c View commit details
    Browse the repository at this point in the history
Loading