From 0bdb345d8b086f94e3726708e06b7e852ed028d2 Mon Sep 17 00:00:00 2001 From: Thibault Dalban Date: Fri, 2 Oct 2020 10:36:40 +0200 Subject: [PATCH 1/3] Fix confusing comments in User model The comments above the dynamodb params in `getByEmail` and `getById` functions were indicating a save instead of a query, probably due to a copy/paste from the `register` function. --- api/models/users.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/models/users.js b/api/models/users.js index cfef68f..b29e60f 100644 --- a/api/models/users.js +++ b/api/models/users.js @@ -67,7 +67,7 @@ const getByEmail = async(email) => { throw new Error(`"${email}" is not a valid email address`) } - // Save + // Query const params = { TableName: process.env.db, KeyConditionExpression: 'hk = :hk', @@ -96,7 +96,7 @@ const getById = async(id) => { throw new Error(`"id" is required`) } - // Save + // Query const params = { TableName: process.env.db, IndexName: process.env.dbIndex1, @@ -133,4 +133,4 @@ module.exports = { getByEmail, getById, convertToPublicFormat, -} \ No newline at end of file +} From ebb5af4c266229090a2f17ae27ff3cd0e7be4757 Mon Sep 17 00:00:00 2001 From: "Eslam A. Hefnawy" Date: Wed, 28 Oct 2020 15:47:58 +0300 Subject: [PATCH 2/3] remove app props as its determined on init --- api/serverless.yml | 1 - database/serverless.yml | 1 - permissions/serverless.yml | 1 - site/serverless.yml | 1 - 4 files changed, 4 deletions(-) diff --git a/api/serverless.yml b/api/serverless.yml index cc209b4..99da196 100644 --- a/api/serverless.yml +++ b/api/serverless.yml @@ -1,4 +1,3 @@ -app: fullstack-app component: express name: api diff --git a/database/serverless.yml b/database/serverless.yml index 631d8a3..f9081af 100644 --- a/database/serverless.yml +++ b/database/serverless.yml @@ -1,5 +1,4 @@ component: aws-dynamodb -app: fullstack-app name: database inputs: diff --git a/permissions/serverless.yml b/permissions/serverless.yml index 9090b9b..5229904 100644 --- a/permissions/serverless.yml +++ b/permissions/serverless.yml @@ -1,5 +1,4 @@ component: aws-iam-role -app: fullstack-app name: permissions inputs: diff --git a/site/serverless.yml b/site/serverless.yml index 3bbf7f5..845044b 100644 --- a/site/serverless.yml +++ b/site/serverless.yml @@ -1,5 +1,4 @@ component: website -app: fullstack-app name: site inputs: From 188365a1a16eb4d1daeee280d0a15d56dd6d672d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eslam=20=CE=BB=20Hefnawy?= Date: Mon, 15 Feb 2021 20:39:25 +0300 Subject: [PATCH 3/3] Update README.md --- README.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 0298f14..bc39dff 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,8 @@ Install the latest version of the Serverless Framework: npm i -g serverless ``` +After installation, make sure you connect your AWS account by setting a provider in the org setting page on the [Serverless Dashboard](https://app.serverless.com). + Then, initialize the `fullstack-app` template: ``` @@ -21,12 +23,9 @@ serverless init fullstack-app cd fullstack-app ``` -Then, add your AWS credentials in the `.env` file in the root directory, like this: +Then, add the following environment variables in an `.env` file in the root directory, like this: ```text -AWS_ACCESS_KEY_ID=JAFJ89109JASFKLJASF -AWS_SECRET_ACCESS_KEY=AJ91J9A0SFA0S9FSKAFLASJFLJ - # This signs you JWT tokens used for auth. Enter a random string in here that's ~40 characters in length. tokenSecret=yourSecretKey