Remove console report

camilamaia · camilamaia · commit 07578eca3f0c · 2020-06-12T10:40:08.000-03:00
diff --git a/README.md b/README.md
@@ -74,18 +74,17 @@ You can find complete examples at [scanapi-examples][scanapi-examples]!
 
 ```bash
 $ scanapi --help
-Usage: scanapi [OPTIONS]
+Usage: scanapi [OPTIONS] [SPEC_PATH]
 
   Automated Testing and Documentation for your REST API.
 
 Options:
-  -s, --spec-path PATH
   -o, --output-path PATH
   -c, --config-path PATH
-  -r, --reporter [console|markdown|html]
+  -r, --reporter [html|markdown]
   -t, --template PATH
-  --log-level [DEBUG|INFO|WARNING|ERROR|CRITICAL]
-  --help                          Show this message and exit.
+  -ll, --log-level [DEBUG|INFO|WARNING|ERROR|CRITICAL]
+  -h, --help                      Show this message and exit.
 ```
 
 ### API Specification Keys
@@ -266,7 +265,7 @@ If you want to configure the ScanAPI with a file, you can create a `.scanapi.yam
 ```yaml
 spec_path: my_path/api.yaml
 output_path: my_path/scanapi-report.md
-reporter: console
+reporter: markdown
 ```
 
 ### Hiding sensitive information
diff --git a/scanapi/main.py b/scanapi/main.py
@@ -4,16 +4,17 @@
 from scanapi.scan import scan
 from scanapi.settings import settings
 
+CONTEXT_SETTINGS = dict(help_option_names=["-h", "--help"])
 
-@click.command()
-@click.option("-s", "--spec-path", "spec_path", type=click.Path(exists=True))
+
+@click.command(context_settings=CONTEXT_SETTINGS)
+@click.argument("spec_path", type=click.Path(exists=True), required=False)
 @click.option("-o", "--output-path", "output_path", type=click.Path())
 @click.option("-c", "--config-path", "config_path", type=click.Path(exists=True))
-@click.option(
-    "-r", "--reporter", "reporter", type=click.Choice(["console", "markdown", "html"])
-)
+@click.option("-r", "--reporter", "reporter", type=click.Choice(["html", "markdown"]))
 @click.option("-t", "--template", "template", type=click.Path(exists=True))
 @click.option(
+    "-ll",
     "--log-level",
     "log_level",
     type=click.Choice(["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"]),
diff --git a/scanapi/reporter.py b/scanapi/reporter.py
@@ -28,10 +28,6 @@ def write(self, responses):
 
         content = self._render_content(loader, template_path, responses)
 
-        if self.reporter == "console":
-            print(f"\n{content}")
-            return
-
         if self.output_path is None:
             outputs = {"html": "scanapi-report.html", "markdown": "scanapi-report.md"}
             self.output_path = outputs.get(self.reporter) or "scanapi-report"
diff --git a/scanapi/templates/console.jinja b/scanapi/templates/console.jinja
diff --git a/tests/unit/test_reporter.py b/tests/unit/test_reporter.py
@@ -7,29 +7,7 @@
 ]
 
 
-class TestConsoleReport:
-    @pytest.fixture
-    def mocked_print(self, mocker):
-        return mocker.patch("builtins.print")
-
-    def test_should_print(self, mocker, mocked_print):
-        console_reporter = Reporter(None, "console")
-        console_reporter.write(fake_responses)
-
-        expected_content = "\n".join(
-            (
-                "ScanAPI Report: Console",
-                "=======================",
-                "",
-                "GET http://test.com - 200",
-                "",
-            )
-        )
-
-        mocked_print.assert_called_once_with(f"\n{expected_content}")
-
-
-class TestReporterOtherThanConsole:
+class TestReporter:
     @pytest.fixture
     def mocked__render_content(self, mocker):
         return mocker.patch("scanapi.reporter.Reporter._render_content")
