Skip to content

Commit 9fe672f

Browse files
committed
Providing error messages when no board is selected.
1 parent 0979ed0 commit 9fe672f

3 files changed

Lines changed: 15 additions & 2 deletions

File tree

app/src/processing/app/Base.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1520,7 +1520,13 @@ static public Target getTarget() {
15201520

15211521

15221522
static public Map<String, String> getBoardPreferences() {
1523-
return getTarget().getBoards().get(Preferences.get("board"));
1523+
Target target = getTarget();
1524+
if (target == null) return new LinkedHashMap();
1525+
Map map = target.getBoards();
1526+
if (map == null) return new LinkedHashMap();
1527+
map = (Map) map.get(Preferences.get("board"));
1528+
if (map == null) return new LinkedHashMap();
1529+
return map;
15241530
}
15251531

15261532

app/src/processing/app/Sketch.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1574,7 +1574,9 @@ public boolean exportApplet(String appletPath, boolean verbose)
15741574
protected void size(String buildPath, String suggestedClassName)
15751575
throws RunnerException {
15761576
long size = 0;
1577-
long maxsize = Integer.parseInt(Base.getBoardPreferences().get("upload.maximum_size"));
1577+
String maxsizeString = Base.getBoardPreferences().get("upload.maximum_size");
1578+
if (maxsizeString == null) return;
1579+
long maxsize = Integer.parseInt(maxsizeString);
15781580
Sizer sizer = new Sizer(buildPath, suggestedClassName);
15791581
try {
15801582
size = sizer.computeSize();

app/src/processing/app/debug/Compiler.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,11 @@ public boolean compile(Sketch sketch,
7373
String avrBasePath = Base.getAvrBasePath();
7474
Map<String, String> boardPreferences = Base.getBoardPreferences();
7575
String core = boardPreferences.get("build.core");
76+
if (core == null) {
77+
RunnerException re = new RunnerException("No board selected; please choose a board from the Tools > Board menu.");
78+
re.hideStackTrace();
79+
throw re;
80+
}
7681
String corePath;
7782

7883
if (core.indexOf(':') == -1) {

0 commit comments

Comments
 (0)