Allow to download artifact#1
Merged
Merged
Conversation
Extends the API by adding a {download_artifact} function which allows
the installation of releases that don't contain a binary (a Nodejs script
for example).
Contributor
Author
|
It might be possible to refactor the code to reuse more, only the extract_tarball changes. I think it's simpler to duplicated our logic a bit, what do you think? |
Contributor
|
@drager do you have any thoughts? |
Owner
|
@ashleygwilliams @xtuc Sorry for the late response! I agree that it would be a good idea to do some refactoring and break down common parts into smaller functions and add some test as well! This can of course be done in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the API by adding a {download_artifact} function which allows
the installation of releases that don't contain a binary (a Nodejs script
for example).
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to binary-install! 😄 ✨✨