Adding Custom Unknown Type Error (#2272)

CursedRock17 · christophebedard · web-flow · commit 65f0b70d4aa4 · 2023-08-15T15:21:33.000-07:00
Signed-off-by: CursedRock17 &lt;mtglucas1@gmail.com&gt;
Co-authored-by: Christophe Bedard &lt;bedard.christophe@gmail.com&gt;
diff --git a/rclcpp/include/rclcpp/exceptions/exceptions.hpp b/rclcpp/include/rclcpp/exceptions/exceptions.hpp
@@ -206,6 +206,14 @@ class UnknownROSArgsError : public std::runtime_error
   const std::vector<std::string> unknown_ros_args;
 };
 
+/// Thrown when an unknown type is passed
+class UnknownTypeError : public std::runtime_error
+{
+public:
+  explicit UnknownTypeError(const std::string & type)
+  : std::runtime_error("Unknown type: " + type) {}
+};
+
 /// Thrown when an invalid rclcpp::Event object or SharedPtr is encountered.
 class InvalidEventError : public std::runtime_error
 {
diff --git a/rclcpp/include/rclcpp/parameter_value.hpp b/rclcpp/include/rclcpp/parameter_value.hpp
@@ -24,6 +24,7 @@
 
 #include "rcl_interfaces/msg/parameter_type.hpp"
 #include "rcl_interfaces/msg/parameter_value.hpp"
+#include "rclcpp/exceptions/exceptions.hpp"
 #include "rclcpp/visibility_control.hpp"
 
 namespace rclcpp
diff --git a/rclcpp/src/rclcpp/parameter_value.cpp b/rclcpp/src/rclcpp/parameter_value.cpp
@@ -129,8 +129,7 @@ ParameterValue::ParameterValue(const rcl_interfaces::msg::ParameterValue & value
     case PARAMETER_NOT_SET:
       break;
     default:
-      // TODO(wjwwood): use custom exception
-      throw std::runtime_error("Unknown type: " + std::to_string(value.type));
+      throw rclcpp::exceptions::UnknownTypeError(std::to_string(value.type));
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,7 @@ ParameterValue::ParameterValue(const rcl_interfaces::msg::ParameterValue & value`
`129`	`129`	`case PARAMETER_NOT_SET:`
`130`	`130`	`break;`
`131`	`131`	`default:`
`132`		`- // TODO(wjwwood): use custom exception`
`133`		`- throw std::runtime_error("Unknown type: " + std::to_string(value.type));`
	`132`	`+ throw rclcpp::exceptions::UnknownTypeError(std::to_string(value.type));`
`134`	`133`	`}`
`135`	`134`	`}`
`136`	`135`