Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: regexaurus/cpython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: regexaurus/cpython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: buildbot-custom
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 24, 2017

  1. bpo-30647: Check nl_langinfo(CODESET) in locale coercion

    - On some versions of FreeBSD, setting the "UTF-8" locale
      succeeds, but a subsequent "nl_langinfo(CODESET)" fails
    - adding a check for this in the coercion logic means that
      coercion will happen on systems where this check succeeds,
      and will be skipped otherwise
    - that way CPython should automatically adapt to changes in
      platform behaviour, rather than needing a new release to
      enable coercion at build time
    - this also allows UTF-8 to be re-enabled as a coercion
      target, restoring the locale coercion behaviour on Mac OS X
    ncoghlan committed Jun 24, 2017
    Configuration menu
    Copy the full SHA
    f051cc5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64a708c View commit details
    Browse the repository at this point in the history
  3. Conditionally check nl_langinfo in locale coercion tests

    The problem with dynamically adaptive tests is that they
    can sometimes pass without actually testing anything useful.
    
    On Linux and Mac OS X, if setlocale works, we also expect
    nl_langinfo(CODESET) to *always* work for the coercion target
    locales. The tests now reflect this by always assuming the
    target locale will work if setlocale succeeds when running
    on Linux or Mac OS X.
    ncoghlan committed Jun 24, 2017
    Configuration menu
    Copy the full SHA
    5f262ef View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2017

  1. Configuration menu
    Copy the full SHA
    f5fe874 View commit details
    Browse the repository at this point in the history
Loading