Skip to content

Small fixes while reviewing the document#7

Merged
vmuriart merged 10 commits into
masterfrom
small-updates
Feb 22, 2017
Merged

Small fixes while reviewing the document#7
vmuriart merged 10 commits into
masterfrom
small-updates

Conversation

@den-run-ai

@den-run-ai den-run-ai commented Feb 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

npython, print(), py36, typo, links, simplified API

@den-run-ai den-run-ai changed the title Update readme.html Small fixes while reviewing the document Feb 19, 2017
@den-run-ai den-run-ai changed the title Small fixes while reviewing the document [WIP ]Small fixes while reviewing the document Feb 19, 2017
@den-run-ai den-run-ai changed the title [WIP ]Small fixes while reviewing the document [WIP] Small fixes while reviewing the document Feb 19, 2017
filmor
filmor reviewed Feb 19, 2017
View reviewed changes

@filmor filmor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mono executable is lowercase. Also it is not strictly necessary to use mono like this (binfmt_misc), I'd just drop that addition.

@den-run-ai

den-run-ai commented Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

Good catch, TIL about binfmt_misc. However it likely requires registration like on Windows.

Here is a quick test:

(root) dta@ubuntune:~/pythonnet$ mono nPython.exe
Python 3.5.2 (default, Nov 17 2016, 17:05:23) 
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> exit()
(root) dta@ubuntune:~/pythonnet$ nPython.exe
nPython.exe: command not found

@den-run-ai den-run-ai changed the title [WIP] Small fixes while reviewing the document Small fixes while reviewing the document Feb 22, 2017
vmuriart
vmuriart reviewed Feb 22, 2017
View reviewed changes
Comment thread readme.html Outdated
<li><a href="#arrays">Using Arrays</a></li>
<li><a href="#collections">Using Collections</a></li>
<li><a href="#com">COM Components</a></li>
<li><a href="#com">COM Componefnts</a></li>

@vmuriart vmuriart Feb 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

@den-run-ai den-run-ai Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

vmuriart
vmuriart reviewed Feb 22, 2017
View reviewed changes
Comment thread readme.html Outdated
@@ -422,8 +422,8 @@ <h2>Exception Handling</h2>
try:
raise NullReferenceException("aiieee!")
except NullReferenceException, e:

@vmuriart vmuriart Feb 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except NullReferenceException as e: for it to be PY3 compatible

@vmuriart vmuriart Feb 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is outside of what you were fixing. Just noticed it while reviewing.

@den-run-ai den-run-ai Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

vmuriart
vmuriart approved these changes Feb 22, 2017
View reviewed changes

@vmuriart vmuriart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ok to squash-merge

@den-run-ai

den-run-ai commented Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

@vmuriart should we defer updating PythonNet to pythonnet?

@vmuriart

vmuriart commented Feb 22, 2017

Copy link
Copy Markdown
Contributor

I didn't see it as part of these changes. Let's not add them yet till we come closer to a decision. PythonNet and pythonnet might both be valid at the end.

@den-run-ai

den-run-ai commented Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

@filmor do you agree with merging this?

@vmuriart vmuriart merged commit 0754d3f into master Feb 22, 2017
@vmuriart vmuriart deleted the small-updates branch February 22, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuriart vmuriart vmuriart approved these changes

@filmor filmor Awaiting requested review from filmor

@tonyroberts tonyroberts Awaiting requested review from tonyroberts

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@den-run-ai @vmuriart @filmor