Require NO_COLOR environment variable to be non-empty to disable colors

geieredgar · geieredgar · commit 01d3a72a0ed1 · 2019-07-22T19:35:39.000+02:00
diff --git a/pre_commit/color.py b/pre_commit/color.py
@@ -48,7 +48,7 @@ def use_color(setting):
     if setting not in COLOR_CHOICES:
         raise InvalidColorSetting(setting)
 
-    if 'NO_COLOR' in os.environ:
+    if 'NO_COLOR' in os.environ and os.environ['NO_COLOR']:
         return False
 
     return (
