From 2bee1b2be3a75703a191182edf33a91b70a6a201 Mon Sep 17 00:00:00 2001 From: Marcelo Moreira de Mello Date: Fri, 10 Mar 2017 18:27:44 -0500 Subject: [PATCH 1/2] Allows to filter history by event kind: 'motion', 'on_demand', 'ding' --- ring_doorbell/__init__.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ring_doorbell/__init__.py b/ring_doorbell/__init__.py index a23b6d26..10fec65e 100644 --- a/ring_doorbell/__init__.py +++ b/ring_doorbell/__init__.py @@ -485,7 +485,7 @@ def existing_doorbell_type_duration(self, value): return True return None - def history(self, limit=30, timezone=None): + def history(self, limit=30, timezone=None, kind=None) : """Return history with datetime objects.""" # allow modify the items to return params = {'limit': str(limit)} @@ -508,6 +508,10 @@ def history(self, limit=30, timezone=None): entry['created_at'] = tz_dt else: entry['created_at'] = utc_dt + + if kind: + return list(filter(lambda array: array['kind'] == kind, response)) + return response @property From dff2064a7b535ae24b3c91a77e1e3017e45a86f9 Mon Sep 17 00:00:00 2001 From: Marcelo Moreira de Mello Date: Fri, 10 Mar 2017 18:34:06 -0500 Subject: [PATCH 2/2] Fixed whitespace --- ring_doorbell/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ring_doorbell/__init__.py b/ring_doorbell/__init__.py index 10fec65e..8fd2fe12 100644 --- a/ring_doorbell/__init__.py +++ b/ring_doorbell/__init__.py @@ -485,7 +485,7 @@ def existing_doorbell_type_duration(self, value): return True return None - def history(self, limit=30, timezone=None, kind=None) : + def history(self, limit=30, timezone=None, kind=None): """Return history with datetime objects.""" # allow modify the items to return params = {'limit': str(limit)}