From 4e5059f9e475302d546ffc7cd50946dd83698a0a Mon Sep 17 00:00:00 2001 From: Marcelo Moreira de Mello Date: Sun, 10 Feb 2019 21:28:30 -0500 Subject: [PATCH] Fixed pylint and test errors --- ring_doorbell/__init__.py | 3 ++- ring_doorbell/doorbot.py | 8 ++++---- tests/test_ring.py | 2 +- tests/test_ring_utils.py | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/ring_doorbell/__init__.py b/ring_doorbell/__init__.py index d9780e6b..99bb9251 100644 --- a/ring_doorbell/__init__.py +++ b/ring_doorbell/__init__.py @@ -191,7 +191,8 @@ def query(self, elif method == 'PUT': req = self.session.put((url), params=urlencode(params)) elif method == 'POST': - req = self.session.post((url), params=urlencode(params), json=json) + req = self.session.post( + (url), params=urlencode(params), json=json) if self.debug: _LOGGER.debug("_query %s ret %s", loop, req.status_code) diff --git a/ring_doorbell/doorbot.py b/ring_doorbell/doorbot.py index adeaf382..0c868d03 100644 --- a/ring_doorbell/doorbot.py +++ b/ring_doorbell/doorbot.py @@ -4,8 +4,8 @@ import logging from datetime import datetime import os -import pytz import time +import pytz from ring_doorbell.generic import RingGeneric @@ -355,9 +355,9 @@ def get_snapshot(self, retries=3, delay=1): request_time = time.time() for _ in range(retries): time.sleep(delay) - response = self._ring.query(url, method="POST", json=payload, - raw=1).json() + response = self._ring.query( + url, method="POST", json=payload, raw=1).json() if response["timestamps"][0]["timestamp"] / 1000 > request_time: return self._ring.query(API_URI + SNAPSHOT_ENDPOINT.format( - self._attrs.get('id')), raw=True).content + self._attrs.get('id')), raw=True).content return False diff --git a/tests/test_ring.py b/tests/test_ring.py index cae84803..4aa0132e 100644 --- a/tests/test_ring.py +++ b/tests/test_ring.py @@ -29,7 +29,7 @@ def test_basic_attributes(self, mock): self.assertEqual(2, len(data.doorbells)) self.assertEqual(1, len(data.stickup_cams)) self.assertFalse(data._persist_token) - self.assertEquals('http://localhost/', data._push_token_notify_url) + self.assertEqual('http://localhost/', data._push_token_notify_url) @requests_mock.Mocker() def test_chime_attributes(self, mock): diff --git a/tests/test_ring_utils.py b/tests/test_ring_utils.py index 10e056ba..1d757ba9 100644 --- a/tests/test_ring_utils.py +++ b/tests/test_ring_utils.py @@ -25,8 +25,8 @@ def tearDown(self): def test_locator(self): """Test _locator method.""" - self.assertEquals(-1, _locator([DATA], 'key', 'bar')) - self.assertEquals(0, _locator([DATA], 'key', 'value')) + self.assertEqual(-1, _locator([DATA], 'key', 'bar')) + self.assertEqual(0, _locator([DATA], 'key', 'value')) def test_initiliaze_clean_cache(self): """Test _clean_cache method."""