Skip to content

bpo-34298: Avoid inefficient way to find start point in deque.index#8589

Closed
hacksg wants to merge 1 commit into
python:masterfrom
hacksg:master
Closed

bpo-34298: Avoid inefficient way to find start point in deque.index#8589
hacksg wants to merge 1 commit into
python:masterfrom
hacksg:master

Conversation

@hacksg

@hacksg hacksg commented Jul 31, 2018

Copy link
Copy Markdown

Replaced the inefficient loop with faster code from deque_item()

https://bugs.python.org/issue34298

Replaced the inefficient loop with faster code from deque_item()
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@hacksg

hacksg commented Aug 1, 2018

Copy link
Copy Markdown
Author

Please bot check agian to remove CLA not signed label

@Mariatta

Mariatta commented Aug 1, 2018

Copy link
Copy Markdown
Member

The commit was made by another user: ksg97031 and that person need to sign CLA too.
Can ksg97031 make the PR instead?

@hacksg

hacksg commented Aug 1, 2018

Copy link
Copy Markdown
Author

Something wrong :(
I will close and request the PR again by the other user(ksg97031)

Thank you

@hacksg hacksg closed this Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants