Skip to content

bpo-46745: Fix typo in PositionsIterator#31322

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
eclipseo:patch-1
Feb 17, 2022
Merged

bpo-46745: Fix typo in PositionsIterator#31322
JelleZijlstra merged 2 commits into
python:mainfrom
eclipseo:patch-1

Conversation

@eclipseo

@eclipseo eclipseo commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@eclipseo

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@eclipseo eclipseo changed the title Fix typo in PositionsIterator bpo-46745: Fix typo in PositionsIterator Feb 14, 2022
Comment thread Objects/codeobject.c Outdated

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this PR in a few days (cc @gvanrossum).

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for this.

@JelleZijlstra

Copy link
Copy Markdown
Member

Yeah I felt like just merging this already would be fine :)

@JelleZijlstra JelleZijlstra merged commit 482a4b6 into python:main Feb 17, 2022
@bedevere-bot

Copy link
Copy Markdown

@JelleZijlstra: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants