Skip to content

bpo-45757: make dis reset extended_arg when op does not have an arg#29480

Merged
iritkatriel merged 3 commits into
python:mainfrom
iritkatriel:bpo-45757-dis-extended-arg
Nov 9, 2021
Merged

bpo-45757: make dis reset extended_arg when op does not have an arg#29480
iritkatriel merged 3 commits into
python:mainfrom
iritkatriel:bpo-45757-dis-extended-arg

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 8, 2021

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! One tiny suggestion for the NEWS entry:

Comment thread Misc/NEWS.d/next/Library/2021-11-08-23-22-14.bpo-45757.MHZHt3.rst Outdated
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@iritkatriel iritkatriel merged commit cb414cf into python:main Nov 9, 2021
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cb414cf0e207668300c4fe3f310c0bd249153273 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2021
…ARG before a no-arg opcode (pythonGH-29480)

(cherry picked from commit cb414cf)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-29502 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 9, 2021
iritkatriel added a commit that referenced this pull request Nov 9, 2021
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@iritkatriel iritkatriel deleted the bpo-45757-dis-extended-arg branch January 13, 2022 15:36
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants