Skip to content

bpo-44959: Added fallback to extension modules with '.sl' suffix on HP-UX#27857

Merged
vstinner merged 4 commits into
python:mainfrom
florinspatar:fix-issue-44959
Sep 8, 2021
Merged

bpo-44959: Added fallback to extension modules with '.sl' suffix on HP-UX#27857
vstinner merged 4 commits into
python:mainfrom
florinspatar:fix-issue-44959

Conversation

@florinspatar

@florinspatar florinspatar commented Aug 20, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Aug 20, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@florinspatar

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@vstinner vstinner closed this Sep 7, 2021
@vstinner vstinner reopened this Sep 7, 2021
@vstinner

vstinner commented Sep 7, 2021

Copy link
Copy Markdown
Member

I closed/reopened the PR to re-run the failed CI job: Address sanitizer (pull_request):

2 tests failed: test__xxsubinterpreters test_multiprocessing_fork

Please ping me once tests pass, I will merge your PR ;-)

vstinner
vstinner approved these changes Sep 7, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The NEWS entry should be in the "Core" category, but I don't care much. Change it it you want (remove the old file, re-run blurb to add a new entry).

florinspatar and others added 2 commits September 8, 2021 11:27
@florinspatar

florinspatar commented Sep 8, 2021

Copy link
Copy Markdown
Contributor Author

Did the requested NEWS change. test_multiprocessing_fork seem to fail randomly

@vstinner vstinner merged commit 2396fa6 into python:main Sep 8, 2021
@vstinner

vstinner commented Sep 8, 2021

Copy link
Copy Markdown
Member

Merged, thanks for your contribution @florinspatar!

@miss-islington

miss-islington commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @florinspatar for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @florinspatar for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 22, 2021
@bedevere-bot

bedevere-bot commented Oct 22, 2021

Copy link
Copy Markdown

GH-29152 is a backport of this pull request to the 3.10 branch.

@bedevere-bot

bedevere-bot commented Oct 22, 2021

Copy link
Copy Markdown

GH-29153 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2021
@florinspatar @miss-islington
bpo-44959: Add fallback to extension modules with '.sl' suffix on HP-…
1bda9dc 
…UX (pythonGH-27857)

(cherry picked from commit 2396fa6)

Co-authored-by: Florin Spătar <florin.spatar@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2021
@florinspatar @miss-islington
bpo-44959: Add fallback to extension modules with '.sl' suffix on HP-…
4c1bec3 
…UX (pythonGH-27857)

(cherry picked from commit 2396fa6)

Co-authored-by: Florin Spătar <florin.spatar@gmail.com>
miss-islington added a commit that referenced this pull request Oct 22, 2021
@miss-islington @florinspatar
bpo-44959: Add fallback to extension modules with '.sl' suffix on HP-…
aa8c344 
…UX (GH-27857)

(cherry picked from commit 2396fa6)

Co-authored-by: Florin Spătar <florin.spatar@gmail.com>
ambv pushed a commit that referenced this pull request Nov 18, 2021
@miss-islington @florinspatar
bpo-44959: Add fallback to extension modules with '.sl' suffix on HP-…
6d66de9 
…UX (GH-27857) (GH-29152)

(cherry picked from commit 2396fa6)

Co-authored-by: Florin Spătar <florin.spatar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@florinspatar @the-knights-who-say-ni @vstinner @miss-islington @bedevere-bot