bpo-39127: Make _Py_HashPointer's argument be const by petdance · Pull Request #17690 · python/cpython

petdance · 2019-12-24T05:01:38Z

_Py_HashPointer in Python/pyhash.c takes a pointer argument that can be made const. This will let compiler and static analyzers know that the pointer's target is not modified. You can also change calls to _Py_HashPointer that are down-casting pointers.

For example, in meth_hash in Objects/methodobject.c, this call can have the void * changed to const void *.

y = _Py_HashPointer((void*)(a->m_ml->ml_meth));

https://bugs.python.org/issue39127

the-knights-who-say-ni · 2019-12-24T05:01:42Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@petdance

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

petdance · 2019-12-24T05:03:18Z

I have indeed signed the CLA, but it was just earlier this evening.

petdance · 2019-12-25T02:47:46Z

@serhiy-storchaka If I find more instances of changes like this, should I submit each one individually, or put them all together in a single PR?

…y argument (GH-17826)

Ignore leading dots and no longer ignore a trailing newline.

…H-17618) No longer import the re module if it is not needed.

…rue. (GH-17616)

tkinter.ttk.Scale().configure([name]) now returns a configuration tuple for name or a list thereof for all options. Based on patch Giovanni Lombardo.

…7837)

…H-17813) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

)

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>

…s well (GH-17694) To be consistent with document layout, it should say when the feature was added. Although it's mentioned few other places in the doc but it's not explicitly say that at that place. https://bugs.python.org/issue39130

…GH-17851)

…17864) Fixes error attempting to bind to IPv4 address.

…-17860)

…H-17818)

…-17872) * `enum.auto()` initial value is now specified as being `1`.

terryjreedy · 2020-02-05T10:59:45Z

I verified that bpo has user petdance with petdance as the github name and with CLA marked signed. I don't know why the bot keeps adding back the unsigned label.

Properly merging the master into this (with git merge origin/master after updating local and origin/master and creating a pr branch) on my machine removed all but 1 of the spurious comments.

The latter was for a duplicate blurb for another issue, which I removed. I don't think that this needs a news item, but however merges can decide.

terryjreedy · 2020-02-05T11:03:50Z

@serhiy-storchaka Do you want to merge as is or should Andy look for other places to add const?

petdance · 2020-02-05T15:21:32Z

Do you want to merge as is or should Andy look for other places to add const?

There are plenty of other places to add const. I suggest that they make the most sense on a case-by-case basis, and this should be merged as-is. I have another branch of constable candidates that I can start working on if this one works out OK.

serhiy-storchaka · 2020-02-05T21:09:31Z

Sorry for the delay. I approved the PR, but I was going to look whether previous additions of const was documented in a NEWS file or elsewhere. I was not sure.

They did not. So this PR does not need a NEWS entry.

As for other places to add const, I want to look on them. I think there should not be much places where const can be added without breaking backward compatibility.

I am merging this PR now because it was open enough time and I do not want to lost it again. Thank you for your contribution @petdance.

petdance · 2020-02-05T21:12:50Z

I'm glad to help. i'll keep looking for other constable functions. I've done lots of consting in the Perl core over the years.

petdance requested a review from tiran as a code owner December 24, 2019 05:01

the-knights-who-say-ni added the CLA not signed label Dec 24, 2019

bedevere-bot added the awaiting review label Dec 24, 2019

serhiy-storchaka approved these changes Dec 24, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Dec 24, 2019

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jan 4, 2020

asottile and others added 19 commits February 4, 2020 21:00

Fix SystemError when nested function has annotation on positional-onl…

d0ddaf2

…y argument (GH-17826)

bpo-39057: Fix urllib.request.proxy_bypass_environment(). (GH-17619)

c9cbf82

Ignore leading dots and no longer ignore a trailing newline.

bpo-39056: Fix handling invalid warning category in the -W option. (G…

c9a8dca

…H-17618) No longer import the re module if it is not needed.

bpo-39055: Reject a trailing \n in base64.b64decode() with validate=T…

2bf6daf

…rue. (GH-17616)

bpo-39152: add missing ttk.Scale.configure return value (GH-17815)

1c62faa

tkinter.ttk.Scale().configure([name]) now returns a configuration tuple for name or a list thereof for all options. Based on patch Giovanni Lombardo.

Fix constant folding optimization for positional only arguments (GH-1…

cfdded0

…7837)

bpo-39200: Correct the error message for range() empty constructor (G…

2fccd8e

…H-17813) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Organise and clean test_positional_only_arg and add more tests (GH-17842

02ae5df

)

Replace links in howto/pyporting.rst with sphinx references (GH-17781)

c533e91

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>

Fix the parameter list of object. _rpow_ (#GH-16477)

8be8032

Minor formatting improvements and fixes to idle.rst (GH-17165)

34290c0

bpo-38907: In http.server script, restore binding to IPv4 on Windows. (…

277f1ec

…GH-17851)

argument-clinic: Simplify multi-line string handling (GH-17852)

38499f9

bpo-38907: Suppress any exception when attempting to set V6ONLY. (GH-…

278a3d0

…17864) Fixes error attempting to bind to IPv4 address.

Fix link to bpo issue in Changelog (GH-17692)

b69bd9d

bpo-39209: Manage correctly multi-line tokens in interactive mode (GH…

e318f0f

…-17860)

bpo-29778: Fix incorrect NULL check in _PyPathConfig_InitDLLPath() (G…

37926ff

…H-17818)

bpo-39234: Doc: enum.auto() incrementation value not specified. (GH…

e5583fb

…-17872) * `enum.auto()` initial value is now specified as being `1`.

pganssle removed request for abalkin, ericsnowcurrently, ericvsmith, ethanfurman, gvanrossum, ilevkivskyi, ncoghlan, pablogsal, pganssle, rhettinger and terryjreedy February 5, 2020 04:08

the-knights-who-say-ni added CLA not signed and removed CLA not signed labels Feb 5, 2020

python deleted a comment from the-knights-who-say-ni Feb 5, 2020

terryjreedy added CLA signed and removed CLA not signed labels Feb 5, 2020

the-knights-who-say-ni added CLA not signed and removed CLA not signed labels Feb 5, 2020

terryjreedy added 2 commits February 5, 2020 05:29

Merge remote-tracking branch 'origin/master' into pr_17690

1509e18

Remove blurb for another issue.

58ae4f7

terryjreedy added the skip news label Feb 5, 2020

terryjreedy removed the CLA not signed label Feb 5, 2020

the-knights-who-say-ni added the CLA not signed label Feb 5, 2020

serhiy-storchaka merged commit 3d06953 into python:master Feb 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-39127: Make _Py_HashPointer's argument be const#17690

bpo-39127: Make _Py_HashPointer's argument be const#17690
serhiy-storchaka merged 298 commits into
python:masterfrom
petdance:const-_Py_HashPointer

petdance commented Dec 24, 2019 •

edited by bedevere-bot

Loading

Uh oh!

the-knights-who-say-ni commented Dec 24, 2019

Uh oh!

petdance commented Dec 24, 2019

Uh oh!

petdance commented Dec 25, 2019

Uh oh!

terryjreedy commented Feb 5, 2020

Uh oh!

terryjreedy commented Feb 5, 2020

Uh oh!

petdance commented Feb 5, 2020

Uh oh!

serhiy-storchaka commented Feb 5, 2020

Uh oh!

petdance commented Feb 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

petdance commented Dec 24, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Dec 24, 2019

CLA Missing

Uh oh!

petdance commented Dec 24, 2019

Uh oh!

petdance commented Dec 25, 2019

Uh oh!

terryjreedy commented Feb 5, 2020

Uh oh!

terryjreedy commented Feb 5, 2020

Uh oh!

petdance commented Feb 5, 2020

Uh oh!

serhiy-storchaka commented Feb 5, 2020

Uh oh!

petdance commented Feb 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

petdance commented Dec 24, 2019 •

edited by bedevere-bot

Loading