Skip to content

Fix typo in ceval.c error message#148860

Merged
picnixz merged 1 commit into
python:mainfrom
Anonymous941:main
Apr 27, 2026
Merged

Fix typo in ceval.c error message#148860
picnixz merged 1 commit into
python:mainfrom
Anonymous941:main

Conversation

@Anonymous941

@Anonymous941 Anonymous941 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Changed finction to function.

@python-cla-bot

python-cla-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Apr 21, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz picnixz changed the title Typo fix Fix typo in ceval.c error message Apr 22, 2026
@picnixz

picnixz commented Apr 22, 2026

Copy link
Copy Markdown
Member

Can you tell me in which case this exception would be raised?

@johnslavik

Copy link
Copy Markdown
Member

@picnixz, the smallest repro for this would be

>>> class E:
...     def __getattribute__(self, n):
...         if n == "__qualname__": raise RuntimeError
...         return super().__getattribute__(n)
... 
... E()(a=1, **{"a": 2})
... 
Traceback (most recent call last):
  File "<python-input-0>", line 6, in <module>
    E()(a=1, **{"a": 2})
    ~~~^^^^^^^^^^^^^^^^^
TypeError: finction got multiple values for keyword argument 'a'

finction is a C fallback to a failing __qualname__.

@picnixz

picnixz commented Apr 22, 2026

Copy link
Copy Markdown
Member

Ok thanks! We could add a NEWS entry but I think it would be a too niche case. I will include this in the commit message (currently travelling)

@picnixz picnixz self-assigned this Apr 22, 2026
@picnixz picnixz merged commit 54a8921 into python:main Apr 27, 2026
66 checks passed
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 27, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @Anonymous941 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @Anonymous941 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @Anonymous941 and @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 54a8921140ba98461ca915fb80a043271c275b51 3.13

@miss-islington-app

Copy link
Copy Markdown

Sorry, @Anonymous941 and @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 54a8921140ba98461ca915fb80a043271c275b51 3.14

@picnixz

picnixz commented Apr 27, 2026

Copy link
Copy Markdown
Member

Oh the backports failed. Well, since we're actually changing an exception message, let's not break doctests if any...

@picnixz picnixz removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 27, 2026
@serhiy-storchaka

Copy link
Copy Markdown
Member

That code (and typo) is new in 3.15.

@picnixz

picnixz commented Apr 27, 2026

Copy link
Copy Markdown
Member

Oh. That's why! well makes sense why it failed then :) thanks for checking!

@serhiy-storchaka

Copy link
Copy Markdown
Member

For reference, #145876.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants