gh-128051: fix tests if sys.float_repr_style is 'legacy' by skirpichev · Pull Request #135908 · python/cpython

skirpichev · 2025-06-25T04:02:37Z

Issue: Broken tests with "legacy" sys.float_repr_style #128051

skirpichev · 2025-06-25T04:05:41Z

Second commit contains more controversial changes, i.e. where short and legacy repr - agree (but this tested on IEEE box!)

vstinner · 2025-06-25T10:04:15Z

        self.assertRegex(repr(c_ulonglong.from_param(20000)), r"^<cparam '[LIQ]' \(20000\)>$")
        self.assertEqual(repr(c_float.from_param(1.5)), "<cparam 'f' (1.5)>")
        self.assertEqual(repr(c_double.from_param(1.5)), "<cparam 'd' (1.5)>")
-        self.assertEqual(repr(c_double.from_param(1e300)), "<cparam 'd' (1e+300)>")


Please don't remove tests. Maybe skip it if if getattr(sys, 'float_repr_style', '') == 'short':.

Any idea why this was added, given we have other c_double test?

The test was added by commit 916610e.

Yes, I know. As well, as other tests in this function, but why? This value fits in double? We have only one test for float/longdouble.

vstinner · 2025-06-25T10:06:50Z

We usually backport tests changes to stable branches to reduce the risk of merge conflicts for following tests changes.

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner · 2025-06-26T09:50:10Z

            WorseStruct().__setstate__({}, b'foo')

+    @unittest.skipUnless(sys.float_repr_style == 'short',
+                         "applies only when using short float repr style")


I would prefer to only skip 1e300 test, rather than skipping the whole test method.

vstinner

LGTM

miss-islington-app · 2025-06-27T10:00:29Z

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…nGH-135908) (cherry picked from commit f3aec60) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

miss-islington-app · 2025-06-27T10:00:36Z

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f3aec60d7a01c5f085a3ef2d6670d46b42b8ddd3 3.13

bedevere-app · 2025-06-27T10:00:39Z

GH-136025 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-06-27T10:07:10Z

GH-136026 is a backport of this pull request to the 3.13 branch.

…n#135908) Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit f3aec60)

…35908) (#136025) gh-128051: Fix tests if sys.float_repr_style is 'legacy' (GH-135908) (cherry picked from commit f3aec60) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

) (#136026) gh-128051: Fix tests if sys.float_repr_style is 'legacy' (#135908) (cherry picked from commit f3aec60) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

…n#135908) Co-authored-by: Victor Stinner <vstinner@python.org>

skirpichev added 2 commits June 25, 2025 07:01

pythongh-128051: fix tests if sys.float_repr_style is 'legacy'

33f984f

+1

57f4824

skirpichev requested a review from vstinner June 25, 2025 04:02

skirpichev requested review from ethanfurman and jaraco as code owners June 25, 2025 04:02

bedevere-app Bot added the awaiting review label Jun 25, 2025

bedevere-app Bot mentioned this pull request Jun 25, 2025

Broken tests with "legacy" sys.float_repr_style #128051

Closed

skirpichev added the skip news label Jun 25, 2025

+ skip builtin doctests

5105ce2

vstinner reviewed Jun 25, 2025

View reviewed changes

vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 25, 2025

skirpichev commented Jun 25, 2025

View reviewed changes

Comment thread Lib/test/test_enum.py Outdated

skirpichev commented Jun 25, 2025

View reviewed changes

Comment thread Lib/test/test_float.py Outdated

skirpichev commented Jun 25, 2025

View reviewed changes

Comment thread Lib/test/test_statistics.py Outdated

skirpichev and others added 3 commits June 25, 2025 16:13

Apply suggestions from code review

2ccc403

Co-authored-by: Victor Stinner <vstinner@python.org>

Merge branch 'master' into fix-legacy-repr-tests

c0ee947

address review: restore test

46c798a

vstinner reviewed Jun 26, 2025

View reviewed changes

+1

878b6a8

vstinner approved these changes Jun 26, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 26, 2025

vstinner merged commit f3aec60 into python:main Jun 27, 2025
43 checks passed

bedevere-app Bot removed the awaiting merge label Jun 27, 2025

miss-islington-app Bot assigned vstinner Jun 27, 2025

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 27, 2025

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 27, 2025

vstinner added a commit to vstinner/cpython that referenced this pull request Jun 27, 2025

pythongh-128051: Fix tests if sys.float_repr_style is 'legacy' (pytho…

8e7d6f2

…n#135908) Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit f3aec60)

skirpichev deleted the fix-legacy-repr-tests branch June 27, 2025 11:38

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025

pythongh-128051: Fix tests if sys.float_repr_style is 'legacy' (pytho…

551f927

…n#135908) Co-authored-by: Victor Stinner <vstinner@python.org>

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-128051: Fix tests if sys.float_repr_style is 'legacy' (pytho…

0b3f665

…n#135908) Co-authored-by: Victor Stinner <vstinner@python.org>

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-128051: Fix tests if sys.float_repr_style is 'legacy' (pytho…

2585b08

…n#135908) Co-authored-by: Victor Stinner <vstinner@python.org>

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025

pythongh-128051: Fix tests if sys.float_repr_style is 'legacy' (pytho…

83bcd76

…n#135908) Co-authored-by: Victor Stinner <vstinner@python.org>

Uh oh!

Uh oh!

Conversation

skirpichev commented Jun 25, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirpichev commented Jun 25, 2025

Uh oh!

vstinner Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

skirpichev Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

vstinner Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

skirpichev Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Jun 27, 2025

Uh oh!

miss-islington-app Bot commented Jun 27, 2025

Uh oh!

bedevere-app Bot commented Jun 27, 2025

Uh oh!

bedevere-app Bot commented Jun 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

skirpichev commented Jun 25, 2025 •

edited by bedevere-app Bot

Loading