Skip to content

gh-132781: Cleanup Code Related to NotShareableError#132782

Merged
ericsnowcurrently merged 9 commits into
python:mainfrom
ericsnowcurrently:not-shareable-error-cleanup
Apr 25, 2025
Merged

gh-132781: Cleanup Code Related to NotShareableError#132782
ericsnowcurrently merged 9 commits into
python:mainfrom
ericsnowcurrently:not-shareable-error-cleanup

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 21, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Key changes:

  • add to internal C-API:
    • _PyErr_FormatV()
    • _PyErr_SetModuleNotFoundError()
    • _PyXIData_GetNotShareableErrorType()
    • _PyXIData_FormatNotShareableError()
  • drop _PyXIData_lookup_context_t and _PyXIData_GetLookupContext()

@bedevere-app bedevere-app Bot mentioned this pull request Apr 21, 2025
Closed
@ericsnowcurrently ericsnowcurrently merged commit cd9536a into python:main Apr 25, 2025
@ericsnowcurrently ericsnowcurrently deleted the not-shareable-error-cleanup branch April 25, 2025 20:43
@picnixz

picnixz commented Apr 26, 2025

Copy link
Copy Markdown
Member

This introduced refleaks which I fixed in #132989.

picnixz added a commit that referenced this pull request Apr 26, 2025
@picnixz
gh-132781: fix refleaks in crossinterp_exceptions.h post gh-132782 (#…
ca12a74 
…132989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently @picnixz