gh-127667: fix more reference leaks in hashlib#127668
Merged
Merged
Conversation
Contributor
|
I'd prefer if this could be broken in two PRs: one for the refactoring, and one for the error branch fixes. |
Member
Author
Sure! I'll split them into two tomorrow. |
f2a0f6f to
9e34c0e
Compare
hashlib error-brancheshashlib
gpshead
approved these changes
Mar 2, 2025
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @picnixz, I could not cleanly backport this to |
|
Sorry, @picnixz, I could not cleanly backport this to |
Member
Author
|
Arf, this one won't backport cleanly because it contains some references to the UBSan failures fixes. |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Mar 3, 2025
- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`. - Correctly free resources in error branches. - Consistently suppress `_setException()` return value when needed. - Collapse `_setException() + return NULL` into a single statement.
|
GH-130783 is a backport of this pull request to the 3.12 branch. |
|
GH-130783 is a backport of this pull request to the 3.12 branch. |
1 similar comment
|
GH-130783 is a backport of this pull request to the 3.12 branch. |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Mar 3, 2025
- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`. - Correctly free resources in error branches. - Consistently suppress `_setException()` return value when needed. - Collapse `_setException() + return NULL` into a single statement.
|
GH-130784 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
that referenced
this pull request
Mar 3, 2025
gh-127667: fix memory leaks in `hashlib` (GH-127668) - Correctly handle `NULL` values returned by `EVP_MD_CTX_md`. - Correctly free resources in error branches. - Consistently suppress `_setException()` return value when needed. - Collapse `_setException() + return NULL` into a single statement. (cherry-picked from commit 0978465)
picnixz
added a commit
that referenced
this pull request
Mar 3, 2025
gh-127667: fix memory leaks in `hashlib` (GH-127668) - Correctly handle `NULL` values returned by `EVP_MD_CTX_md`. - Correctly free resources in error branches. - Consistently suppress `_setException()` return value when needed. - Collapse `_setException() + return NULL` into a single statement. (cherry-picked from commit 0978465)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the liberty of changing how exceptions are being set in(this will be in a follow-up PR)hashlibbecause_setException(PyExc_ValueError, NULL);is honestly confusing (namely) that "NULL" stands for a default message when the OpenSSL error message cannot be retrieved).In this PR we:
_setException() + returninto one statement when possible; and_setException().hashlib#127667