gh-127165: Disallow embedded NULL characters in _interpreters#127199
Merged
Conversation
picnixz
reviewed
Nov 27, 2024
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
kumaraditya303
approved these changes
Dec 1, 2024
|
Thanks @ZeroIntensity for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 1, 2024
…pythonGH-127199) (cherry picked from commit 46bfd26) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-127463 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Dec 1, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 2, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, null characters in shared namespaces cause truncation of the actual string, because it's eventually passed to
PyUnicode_FromString, which uses thestrleninstead of the actual size. Then, things break because the string unexpectedly is not in the namespace dictionary. This fixes that by just raising if we find an embedded NULL character in_copy_string_obj_raw.We could support embedded NULLs by storing the size alongside the name, but this is much simpler (and in practice, nobody is trying to name variables containing
\x00).concurrent.futures.interpreter.WorkerContext#127165