[3.13] Add the Python 3.13 abidump, and enable the ABI check.#122583
Merged
Conversation
hugovk
reviewed
Aug 1, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Member
Author
|
Should those changes be made to 3.12 as well? |
Member
|
The actions have already been updated in 3.12 (#116948). The URL update doesn't seem important enough on its own, there's a redirect in place. |
hugovk
approved these changes
Aug 2, 2024
encukou
approved these changes
Aug 2, 2024
encukou
left a comment
Member
There was a problem hiding this comment.
With ubuntu-latest we might get spurious ABI complaints when Ubuntu updates. But it's just one of the ways that update might bite us, and this one should be easy to solve/revisit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we're in release-candidate mode, add the Python 3.13 ABI dump file, and enable the ABI check workflow. (Copied from the 3.12 workflow with s/ubuntu-22.04/ubuntu-latest/ since that seems to be the fashion now.)
📚 Documentation preview 📚: https://cpython-previews--122583.org.readthedocs.build/