Skip to content

GH-121131: Clean up and fix some instrumented instructions.#121132

Merged
markshannon merged 4 commits into
python:mainfrom
faster-cpython:tidy-up-instrumented
Jul 26, 2024
Merged

GH-121131: Clean up and fix some instrumented instructions.#121132
markshannon merged 4 commits into
python:mainfrom
faster-cpython:tidy-up-instrumented

Conversation

@markshannon

@markshannon markshannon commented Jun 28, 2024

Copy link
Copy Markdown
Member

This was supposed to be just a refactoring, but it exposed #121131.

  • Add support for prev_instr in the code generator.
  • Use that to move INSTRUMENTED_LINE to bytecodes.c
  • Fix bug in INSTRUMENTED_YIELD_VALUE.

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@markshannon markshannon merged commit afb0aa6 into python:main Jul 26, 2024
@markshannon markshannon deleted the tidy-up-instrumented branch August 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants