Skip to content

gh-120584: Fix "unused thread_critical_sections" warning in test_critical_sections#120585

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-120584
Jun 16, 2024
Merged

gh-120584: Fix "unused thread_critical_sections" warning in test_critical_sections#120585
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-120584

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels Jun 16, 2024
@sobolevn sobolevn requested a review from colesbury June 16, 2024 12:35
@bedevere-app bedevere-app Bot mentioned this pull request Jun 16, 2024
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jun 16, 2024
corona10
corona10 approved these changes Jun 16, 2024
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sobolevn sobolevn merged commit b337aef into python:main Jun 16, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 16, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2024
@sobolevn @miss-islington
pythongh-120584: Fix "unused thread_critical_sections" warning in `te…
5e449b4 
…st_critical_sections` (pythonGH-120585)

(cherry picked from commit b337aef)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-app Bot commented Jun 16, 2024

Copy link
Copy Markdown

GH-120592 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 16, 2024
@sobolevn

sobolevn commented Jun 16, 2024

Copy link
Copy Markdown
Member Author

Thank you!

sobolevn added a commit that referenced this pull request Jun 16, 2024
@miss-islington @sobolevn
[3.13] gh-120584: Fix "unused thread_critical_sections" warning in `t…
6ee68fb 
…est_critical_sections` (GH-120585) (#120592)

gh-120584: Fix "unused thread_critical_sections" warning in `test_critical_sections` (GH-120585)
(cherry picked from commit b337aef)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@sobolevn @mrahtz
pythongh-120584: Fix "unused thread_critical_sections" warning in `te…
cf8bbb8 
…st_critical_sections` (python#120585)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @noahbkim
pythongh-120584: Fix "unused thread_critical_sections" warning in `te…
27247d6 
…st_critical_sections` (python#120585)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-120584: Fix "unused thread_critical_sections" warning in `te…
3f99795 
…st_critical_sections` (python#120585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@colesbury colesbury Awaiting requested review from colesbury

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @corona10