Skip to content

Correct 416 status code enum name#11689

Merged
methane merged 1 commit into
python:masterfrom
pgjones:master
Jan 31, 2019
Merged

Correct 416 status code enum name#11689
methane merged 1 commit into
python:masterfrom
pgjones:master

Conversation

@pgjones

@pgjones pgjones commented Jan 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

See Lib/http/__init__.py#L97, it is REQUESTED_RANGE_NOT_SATISFIABLE
rather than REQUEST_RANGE_NOT_SATISFIABLE.

I think this is a trivial change that doesn't need an issue (Trivial changes, like fixing a typo, do not need an issue.).

@pgjones
Correct 416 status code enum name
ebed8fc 
See Lib/http/__init__.py#L97, it is `REQUESTED_RANGE_NOT_SATISFIABLE` 
rather than `REQUEST_RANGE_NOT_SATISFIABLE`.
@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 28, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 28, 2019
eamanu
eamanu approved these changes Jan 28, 2019
View reviewed changes

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is reasonable fix. You Must sign CLA, first.

@pgjones

pgjones commented Jan 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've just signed it - does it take a while to propagate?

@eamanu

eamanu commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

I've signed it - just it take a while to propagate?

Yes

@eamanu

eamanu commented Jan 30, 2019

Copy link
Copy Markdown
Contributor

Hi @pgjones if you don't receive feedback by some core dev in a couple of day, please open a issue on bpo.

@methane methane added type-bug An unexpected behavior, bug, or error skip issue skip news needs backport to 3.7 labels Jan 31, 2019
@methane methane merged commit d97daeb into python:master Jan 31, 2019
@miss-islington

miss-islington commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

Thanks @pgjones for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@methane

methane commented Jan 31, 2019

Copy link
Copy Markdown
Member

thanks

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2019
@pgjones @miss-islington
doc: http: Fix enum name for status code 416 (pythonGH-11689)
f6ecfa5 
(cherry picked from commit d97daeb)

Co-authored-by: Phil Jones <philip.graham.jones@googlemail.com>
@bedevere-bot

bedevere-bot commented Jan 31, 2019

Copy link
Copy Markdown

GH-11713 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 31, 2019
@miss-islington @pgjones
doc: http: Fix enum name for status code 416 (GH-11689)
09b66e0 
(cherry picked from commit d97daeb)

Co-authored-by: Phil Jones <philip.graham.jones@googlemail.com>
@pgjones

pgjones commented Jan 31, 2019

Copy link
Copy Markdown
Contributor Author

Thank you.

@eamanu

eamanu commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

@pgjones has been added to ACK, @methane?

@methane

methane commented Feb 1, 2019

Copy link
Copy Markdown
Member

@eamanu Good question. I forgot about Misc/ACKS.
I confirmed about it. https://devguide.python.org/pullrequest/#crediting

So trivial change which doesn't require NEWs entry, doesn't require ACKS entry too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@eamanu eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pgjones @the-knights-who-say-ni @eamanu @miss-islington @methane @bedevere-bot