replace k&r function declarations with ANSI declarations#114818
Merged
Conversation
Contributor
Author
|
I think this probably doesn't require issue / news entry, since it's just a minor internal cleanup. Let me know if it's needed though and I can create them. |
Contributor
Author
|
This is required for c23 which removes support for K&R function declarations |
Member
|
Beware, PR's with only code formatting changes are usually rejected, see https://devguide.python.org/getting-started/pull-request-lifecycle/#making-good-prs |
Contributor
Author
|
In this specific case this is required for compilation with C23 since K&R functions have been removed (up to C23 they are deprecated). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
skirpichev
approved these changes
Sep 30, 2024
alex
approved these changes
Mar 11, 2025
Member
|
Merged, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the only three occurrences of K&R style function declaration with the ANSI notation used everywhere else in the code base. This is required to compile with C23 since K&R style functions declarations got removed in C23.