Is this needed? They already contain their own .gitignore:

❯ cat .ruff_cache/.gitignore
*
❯ cat ./Lib/test/.ruff_cache/.gitignore
*

Is this needed? They already contain their own .gitignore:

❯ cat .ruff_cache/.gitignore
*
❯ cat ./Lib/test/.ruff_cache/.gitignore
*

Ah, good point. Yes, I seem to have a .ruff_cache directory locally inside my cpython clone, but it doesn't show up when I do git status.

I think that different tools treat * a bit differently, for example, my editor shows that .ruff_cache folder is not ignored, but its content is ignored:

Compare colors with build/ which is fully ignored.

I think that different tools treat * a bit differently, for example, my editor [...]

I feel like tools should probably parse .gitignore files the same way git does? This feels like it's maybe something that should be reported as a bug to your editor

Looks like VSCode is consistent with git check-ignore

~/Desktop/cpython  main ✔                                                                 
» git check-ignore -v .ruff_cache
                                                                                           
~/Desktop/cpython  main ✔                                                              1 ⚠️
» git checkout ruff-cache-ignore                       
Switched to branch 'ruff-cache-ignore'
Your branch is up to date with 'fork/ruff-cache-ignore'.
                                                                                           
~/Desktop/cpython  ruff-cache-ignore ✔                                                    
» git check-ignore -v .ruff_cache
.gitignore:45:.ruff_cache/      .ruff_cache

I don't really care enough about this change to continue this discussion.

yeah, I don't really care too much either. If git check-ignore says .ruff_cache isn't ignored (even though everything in it is), and this change helps out VSCode users, that's good enough for me. One extra line in .gitignore isn't a massive maintenance burden ;)

I'll wait to see if @hugovk agrees, though.

Sure, fine to add it.

But now I'm curious...

build is ignored by the top-level .gitignore:

❯ git check-ignore -v build
.gitignore:119:/build/	build

The .ruff_cache directory isn't ignored.

❯ git check-ignore -v .ruff_cache

But Git only tracks files, not directories!

And the files in that directory are correctly ignored:

❯ git check-ignore -v .ruff_cache/CACHEDIR.TAG
.ruff_cache/.gitignore:1:*	.ruff_cache/CACHEDIR.TAG

So that all tracks.

I just installed VSCode, but nothing is showing as ignored. Do you need to do something to enable Git ignoring?

With PyCharm you need to open a relevant .gitignore file and tell it to ignore the contents. Here we see some orange dirs ignored, but not the Ruff one:

( sorry, I am preparing a conference talk, so I cannot continue digging :( )