Skip to content

[3.7] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300)#10301

Merged
miss-islington merged 1 commit into
python:3.7from
izbyshev:backport-e2ed5ad-3.7
Nov 3, 2018
Merged

[3.7] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300)#10301
miss-islington merged 1 commit into
python:3.7from
izbyshev:backport-e2ed5ad-3.7

Conversation

@izbyshev

@izbyshev izbyshev commented Nov 2, 2018

Copy link
Copy Markdown
Contributor

Use __GNUC__ instead of non-existing __GNUC_MAJOR__.

(cherry picked from commit e2ed5ad)

https://bugs.python.org/issue35147

Use `__GNUC__` instead of non-existing `__GNUC_MAJOR__`.

https://bugs.python.org/issue35147.
(cherry picked from commit e2ed5ad)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

vstinner commented Nov 2, 2018

Copy link
Copy Markdown
Member

I don't understand why, the AppVeyor job never started. I closed/reopened the issue to workaround the issue.

@Mariatta

Mariatta commented Nov 3, 2018

Copy link
Copy Markdown
Member

I'm checking why the automerge isn't working. Probably ratelimit issue. Please don't merge until I've resolved the issue. Thanks.

@Mariatta

Mariatta commented Nov 3, 2018

Copy link
Copy Markdown
Member

Ah, it does not have "CLA signed" label.

@miss-islington miss-islington merged commit a9122d1 into python:3.7 Nov 3, 2018
@izbyshev izbyshev deleted the backport-e2ed5ad-3.7 branch November 3, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants